manager_test.go 47 KB

1234567891011121314151617181920212223242526272829303132333435363738394041424344454647484950515253545556575859606162636465666768697071727374757677787980818283848586878889909192939495969798991001011021031041051061071081091101111121131141151161171181191201211221231241251261271281291301311321331341351361371381391401411421431441451461471481491501511521531541551561571581591601611621631641651661671681691701711721731741751761771781791801811821831841851861871881891901911921931941951961971981992002012022032042052062072082092102112122132142152162172182192202212222232242252262272282292302312322332342352362372382392402412422432442452462472482492502512522532542552562572582592602612622632642652662672682692702712722732742752762772782792802812822832842852862872882892902912922932942952962972982993003013023033043053063073083093103113123133143153163173183193203213223233243253263273283293303313323333343353363373383393403413423433443453463473483493503513523533543553563573583593603613623633643653663673683693703713723733743753763773783793803813823833843853863873883893903913923933943953963973983994004014024034044054064074084094104114124134144154164174184194204214224234244254264274284294304314324334344354364374384394404414424434444454464474484494504514524534544554564574584594604614624634644654664674684694704714724734744754764774784794804814824834844854864874884894904914924934944954964974984995005015025035045055065075085095105115125135145155165175185195205215225235245255265275285295305315325335345355365375385395405415425435445455465475485495505515525535545555565575585595605615625635645655665675685695705715725735745755765775785795805815825835845855865875885895905915925935945955965975985996006016026036046056066076086096106116126136146156166176186196206216226236246256266276286296306316326336346356366376386396406416426436446456466476486496506516526536546556566576586596606616626636646656666676686696706716726736746756766776786796806816826836846856866876886896906916926936946956966976986997007017027037047057067077087097107117127137147157167177187197207217227237247257267277287297307317327337347357367377387397407417427437447457467477487497507517527537547557567577587597607617627637647657667677687697707717727737747757767777787797807817827837847857867877887897907917927937947957967977987998008018028038048058068078088098108118128138148158168178188198208218228238248258268278288298308318328338348358368378388398408418428438448458468478488498508518528538548558568578588598608618628638648658668678688698708718728738748758768778788798808818828838848858868878888898908918928938948958968978988999009019029039049059069079089099109119129139149159169179189199209219229239249259269279289299309319329339349359369379389399409419429439449459469479489499509519529539549559569579589599609619629639649659669679689699709719729739749759769779789799809819829839849859869879889899909919929939949959969979989991000100110021003100410051006100710081009101010111012101310141015101610171018101910201021102210231024102510261027102810291030103110321033103410351036103710381039104010411042104310441045104610471048104910501051105210531054105510561057105810591060106110621063106410651066106710681069107010711072107310741075107610771078107910801081108210831084108510861087108810891090109110921093109410951096109710981099110011011102110311041105110611071108110911101111111211131114111511161117111811191120112111221123112411251126112711281129113011311132113311341135113611371138113911401141114211431144114511461147114811491150115111521153115411551156115711581159116011611162116311641165116611671168116911701171117211731174117511761177117811791180118111821183118411851186118711881189119011911192119311941195119611971198119912001201120212031204120512061207120812091210121112121213121412151216121712181219122012211222122312241225122612271228122912301231123212331234123512361237123812391240124112421243124412451246124712481249125012511252125312541255125612571258125912601261126212631264126512661267126812691270127112721273127412751276127712781279128012811282128312841285128612871288128912901291129212931294129512961297129812991300130113021303130413051306130713081309131013111312131313141315131613171318131913201321132213231324132513261327132813291330133113321333133413351336133713381339134013411342
  1. package user
  2. import (
  3. "database/sql"
  4. "fmt"
  5. "github.com/stretchr/testify/require"
  6. "github.com/stripe/stripe-go/v74"
  7. "golang.org/x/crypto/bcrypt"
  8. "heckel.io/ntfy/v2/util"
  9. "net/netip"
  10. "path/filepath"
  11. "strings"
  12. "testing"
  13. "time"
  14. )
  15. const minBcryptTimingMillis = int64(40) // Ideally should be >100ms, but this should also run on a Raspberry Pi without massive resources
  16. func TestManager_FullScenario_Default_DenyAll(t *testing.T) {
  17. a := newTestManagerFromFile(t, filepath.Join(t.TempDir(), "user.db"), "", PermissionDenyAll, DefaultUserPasswordBcryptCost, DefaultUserStatsQueueWriterInterval)
  18. require.Nil(t, a.AddUser("phil", "phil", RoleAdmin, false))
  19. require.Nil(t, a.AddUser("ben", "ben", RoleUser, false))
  20. require.Nil(t, a.AddUser("john", "john", RoleUser, false))
  21. require.Nil(t, a.AllowAccess("ben", "mytopic", PermissionReadWrite))
  22. require.Nil(t, a.AllowAccess("ben", "readme", PermissionRead))
  23. require.Nil(t, a.AllowAccess("ben", "writeme", PermissionWrite))
  24. require.Nil(t, a.AllowAccess("ben", "everyonewrite", PermissionDenyAll)) // How unfair!
  25. require.Nil(t, a.AllowAccess("john", "*", PermissionRead))
  26. require.Nil(t, a.AllowAccess("john", "mytopic*", PermissionReadWrite))
  27. require.Nil(t, a.AllowAccess("john", "mytopic_ro*", PermissionRead))
  28. require.Nil(t, a.AllowAccess("john", "mytopic_deny*", PermissionDenyAll))
  29. require.Nil(t, a.AllowAccess(Everyone, "announcements", PermissionRead))
  30. require.Nil(t, a.AllowAccess(Everyone, "everyonewrite", PermissionReadWrite))
  31. require.Nil(t, a.AllowAccess(Everyone, "up*", PermissionWrite)) // Everyone can write to /up*
  32. phil, err := a.Authenticate("phil", "phil")
  33. require.Nil(t, err)
  34. require.Equal(t, "phil", phil.Name)
  35. require.True(t, strings.HasPrefix(phil.Hash, "$2a$10$"))
  36. require.Equal(t, RoleAdmin, phil.Role)
  37. philGrants, err := a.Grants("phil")
  38. require.Nil(t, err)
  39. require.Equal(t, []Grant{}, philGrants)
  40. ben, err := a.Authenticate("ben", "ben")
  41. require.Nil(t, err)
  42. require.Equal(t, "ben", ben.Name)
  43. require.True(t, strings.HasPrefix(ben.Hash, "$2a$10$"))
  44. require.Equal(t, RoleUser, ben.Role)
  45. benGrants, err := a.Grants("ben")
  46. require.Nil(t, err)
  47. require.Equal(t, []Grant{
  48. {"everyonewrite", PermissionDenyAll},
  49. {"mytopic", PermissionReadWrite},
  50. {"writeme", PermissionWrite},
  51. {"readme", PermissionRead},
  52. }, benGrants)
  53. john, err := a.Authenticate("john", "john")
  54. require.Nil(t, err)
  55. require.Equal(t, "john", john.Name)
  56. require.True(t, strings.HasPrefix(john.Hash, "$2a$10$"))
  57. require.Equal(t, RoleUser, john.Role)
  58. johnGrants, err := a.Grants("john")
  59. require.Nil(t, err)
  60. require.Equal(t, []Grant{
  61. {"mytopic_deny*", PermissionDenyAll},
  62. {"mytopic_ro*", PermissionRead},
  63. {"mytopic*", PermissionReadWrite},
  64. {"*", PermissionRead},
  65. }, johnGrants)
  66. notben, err := a.Authenticate("ben", "this is wrong")
  67. require.Nil(t, notben)
  68. require.Equal(t, ErrUnauthenticated, err)
  69. // Admin can do everything
  70. require.Nil(t, a.Authorize(phil, "sometopic", PermissionWrite))
  71. require.Nil(t, a.Authorize(phil, "mytopic", PermissionRead))
  72. require.Nil(t, a.Authorize(phil, "readme", PermissionWrite))
  73. require.Nil(t, a.Authorize(phil, "writeme", PermissionWrite))
  74. require.Nil(t, a.Authorize(phil, "announcements", PermissionWrite))
  75. require.Nil(t, a.Authorize(phil, "everyonewrite", PermissionWrite))
  76. // User cannot do everything
  77. require.Nil(t, a.Authorize(ben, "mytopic", PermissionWrite))
  78. require.Nil(t, a.Authorize(ben, "mytopic", PermissionRead))
  79. require.Nil(t, a.Authorize(ben, "readme", PermissionRead))
  80. require.Equal(t, ErrUnauthorized, a.Authorize(ben, "readme", PermissionWrite))
  81. require.Equal(t, ErrUnauthorized, a.Authorize(ben, "writeme", PermissionRead))
  82. require.Nil(t, a.Authorize(ben, "writeme", PermissionWrite))
  83. require.Nil(t, a.Authorize(ben, "writeme", PermissionWrite))
  84. require.Equal(t, ErrUnauthorized, a.Authorize(ben, "everyonewrite", PermissionRead))
  85. require.Equal(t, ErrUnauthorized, a.Authorize(ben, "everyonewrite", PermissionWrite))
  86. require.Nil(t, a.Authorize(ben, "announcements", PermissionRead))
  87. require.Equal(t, ErrUnauthorized, a.Authorize(ben, "announcements", PermissionWrite))
  88. // User john should have
  89. // "deny" to mytopic_deny*,
  90. // "ro" to mytopic_ro*,
  91. // "rw" to mytopic*,
  92. // "ro" to the rest
  93. require.Equal(t, ErrUnauthorized, a.Authorize(john, "mytopic_deny_case", PermissionRead))
  94. require.Equal(t, ErrUnauthorized, a.Authorize(john, "mytopic_deny_case", PermissionWrite))
  95. require.Nil(t, a.Authorize(john, "mytopic_ro_test_case", PermissionRead))
  96. require.Equal(t, ErrUnauthorized, a.Authorize(john, "mytopic_ro_test_case", PermissionWrite))
  97. require.Nil(t, a.Authorize(john, "mytopic_case1", PermissionRead))
  98. require.Nil(t, a.Authorize(john, "mytopic_case1", PermissionWrite))
  99. require.Nil(t, a.Authorize(john, "readme", PermissionRead))
  100. require.Equal(t, ErrUnauthorized, a.Authorize(john, "writeme", PermissionWrite))
  101. // Everyone else can do barely anything
  102. require.Equal(t, ErrUnauthorized, a.Authorize(nil, "sometopicnotinthelist", PermissionRead))
  103. require.Equal(t, ErrUnauthorized, a.Authorize(nil, "sometopicnotinthelist", PermissionWrite))
  104. require.Equal(t, ErrUnauthorized, a.Authorize(nil, "mytopic", PermissionRead))
  105. require.Equal(t, ErrUnauthorized, a.Authorize(nil, "mytopic", PermissionWrite))
  106. require.Equal(t, ErrUnauthorized, a.Authorize(nil, "readme", PermissionRead))
  107. require.Equal(t, ErrUnauthorized, a.Authorize(nil, "readme", PermissionWrite))
  108. require.Equal(t, ErrUnauthorized, a.Authorize(nil, "writeme", PermissionRead))
  109. require.Equal(t, ErrUnauthorized, a.Authorize(nil, "writeme", PermissionWrite))
  110. require.Equal(t, ErrUnauthorized, a.Authorize(nil, "announcements", PermissionWrite))
  111. require.Nil(t, a.Authorize(nil, "announcements", PermissionRead))
  112. require.Nil(t, a.Authorize(nil, "everyonewrite", PermissionRead))
  113. require.Nil(t, a.Authorize(nil, "everyonewrite", PermissionWrite))
  114. require.Nil(t, a.Authorize(nil, "up1234", PermissionWrite)) // Wildcard permission
  115. require.Nil(t, a.Authorize(nil, "up5678", PermissionWrite))
  116. }
  117. func TestManager_Access_Order_LengthWriteRead(t *testing.T) {
  118. // This test validates issue #914 / #917, i.e. that write permissions are prioritized over read permissions,
  119. // and longer ACL rules are prioritized as well.
  120. a := newTestManagerFromFile(t, filepath.Join(t.TempDir(), "user.db"), "", PermissionDenyAll, DefaultUserPasswordBcryptCost, DefaultUserStatsQueueWriterInterval)
  121. require.Nil(t, a.AddUser("ben", "ben", RoleUser, false))
  122. require.Nil(t, a.AllowAccess("ben", "test*", PermissionReadWrite))
  123. require.Nil(t, a.AllowAccess("ben", "*", PermissionRead))
  124. ben, err := a.Authenticate("ben", "ben")
  125. require.Nil(t, err)
  126. require.Nil(t, a.Authorize(ben, "any-topic-can-be-read", PermissionRead))
  127. require.Nil(t, a.Authorize(ben, "this-too", PermissionRead))
  128. require.Nil(t, a.Authorize(ben, "test123", PermissionWrite))
  129. }
  130. func TestManager_AddUser_Invalid(t *testing.T) {
  131. a := newTestManager(t, PermissionDenyAll)
  132. require.Equal(t, ErrInvalidArgument, a.AddUser(" invalid ", "pass", RoleAdmin, false))
  133. require.Equal(t, ErrInvalidArgument, a.AddUser("validuser", "pass", "invalid-role", false))
  134. }
  135. func TestManager_AddUser_Timing(t *testing.T) {
  136. a := newTestManagerFromFile(t, filepath.Join(t.TempDir(), "user.db"), "", PermissionDenyAll, DefaultUserPasswordBcryptCost, DefaultUserStatsQueueWriterInterval)
  137. start := time.Now().UnixMilli()
  138. require.Nil(t, a.AddUser("user", "pass", RoleAdmin, false))
  139. require.GreaterOrEqual(t, time.Now().UnixMilli()-start, minBcryptTimingMillis)
  140. }
  141. func TestManager_AddUser_And_Query(t *testing.T) {
  142. a := newTestManagerFromFile(t, filepath.Join(t.TempDir(), "user.db"), "", PermissionDenyAll, DefaultUserPasswordBcryptCost, DefaultUserStatsQueueWriterInterval)
  143. require.Nil(t, a.AddUser("user", "pass", RoleAdmin, false))
  144. require.Nil(t, a.ChangeBilling("user", &Billing{
  145. StripeCustomerID: "acct_123",
  146. StripeSubscriptionID: "sub_123",
  147. StripeSubscriptionStatus: stripe.SubscriptionStatusActive,
  148. StripeSubscriptionInterval: stripe.PriceRecurringIntervalMonth,
  149. StripeSubscriptionPaidUntil: time.Now().Add(time.Hour),
  150. StripeSubscriptionCancelAt: time.Unix(0, 0),
  151. }))
  152. u, err := a.User("user")
  153. require.Nil(t, err)
  154. require.Equal(t, "user", u.Name)
  155. u2, err := a.UserByID(u.ID)
  156. require.Nil(t, err)
  157. require.Equal(t, u.Name, u2.Name)
  158. u3, err := a.UserByStripeCustomer("acct_123")
  159. require.Nil(t, err)
  160. require.Equal(t, u.ID, u3.ID)
  161. }
  162. func TestManager_MarkUserRemoved_RemoveDeletedUsers(t *testing.T) {
  163. a := newTestManager(t, PermissionDenyAll)
  164. // Create user, add reservations and token
  165. require.Nil(t, a.AddUser("user", "pass", RoleAdmin, false))
  166. require.Nil(t, a.AddReservation("user", "mytopic", PermissionRead))
  167. u, err := a.User("user")
  168. require.Nil(t, err)
  169. require.False(t, u.Deleted)
  170. token, err := a.CreateToken(u.ID, "", time.Now().Add(time.Hour), netip.IPv4Unspecified())
  171. require.Nil(t, err)
  172. u, err = a.Authenticate("user", "pass")
  173. require.Nil(t, err)
  174. _, err = a.AuthenticateToken(token.Value)
  175. require.Nil(t, err)
  176. reservations, err := a.Reservations("user")
  177. require.Nil(t, err)
  178. require.Equal(t, 1, len(reservations))
  179. // Mark deleted: cannot auth anymore, and all reservations are gone
  180. require.Nil(t, a.MarkUserRemoved(u))
  181. _, err = a.Authenticate("user", "pass")
  182. require.Equal(t, ErrUnauthenticated, err)
  183. _, err = a.AuthenticateToken(token.Value)
  184. require.Equal(t, ErrUnauthenticated, err)
  185. reservations, err = a.Reservations("user")
  186. require.Nil(t, err)
  187. require.Equal(t, 0, len(reservations))
  188. // Make sure user is still there
  189. u, err = a.User("user")
  190. require.Nil(t, err)
  191. require.True(t, u.Deleted)
  192. _, err = a.db.Exec("UPDATE user SET deleted = ? WHERE id = ?", time.Now().Add(-1*(userHardDeleteAfterDuration+time.Hour)).Unix(), u.ID)
  193. require.Nil(t, err)
  194. require.Nil(t, a.RemoveDeletedUsers())
  195. _, err = a.User("user")
  196. require.Equal(t, ErrUserNotFound, err)
  197. }
  198. func TestManager_CreateToken_Only_Lower(t *testing.T) {
  199. a := newTestManager(t, PermissionDenyAll)
  200. // Create user, add reservations and token
  201. require.Nil(t, a.AddUser("user", "pass", RoleAdmin, false))
  202. u, err := a.User("user")
  203. require.Nil(t, err)
  204. token, err := a.CreateToken(u.ID, "", time.Now().Add(time.Hour), netip.IPv4Unspecified())
  205. require.Nil(t, err)
  206. require.Equal(t, token.Value, strings.ToLower(token.Value))
  207. }
  208. func TestManager_UserManagement(t *testing.T) {
  209. a := newTestManager(t, PermissionDenyAll)
  210. require.Nil(t, a.AddUser("phil", "phil", RoleAdmin, false))
  211. require.Nil(t, a.AddUser("ben", "ben", RoleUser, false))
  212. require.Nil(t, a.AllowAccess("ben", "mytopic", PermissionReadWrite))
  213. require.Nil(t, a.AllowAccess("ben", "readme", PermissionRead))
  214. require.Nil(t, a.AllowAccess("ben", "writeme", PermissionWrite))
  215. require.Nil(t, a.AllowAccess("ben", "everyonewrite", PermissionDenyAll)) // How unfair!
  216. require.Nil(t, a.AllowAccess(Everyone, "announcements", PermissionRead))
  217. require.Nil(t, a.AllowAccess(Everyone, "everyonewrite", PermissionReadWrite))
  218. // Query user details
  219. phil, err := a.User("phil")
  220. require.Nil(t, err)
  221. require.Equal(t, "phil", phil.Name)
  222. require.True(t, strings.HasPrefix(phil.Hash, "$2a$04$")) // Min cost for testing
  223. require.Equal(t, RoleAdmin, phil.Role)
  224. philGrants, err := a.Grants("phil")
  225. require.Nil(t, err)
  226. require.Equal(t, []Grant{}, philGrants)
  227. ben, err := a.User("ben")
  228. require.Nil(t, err)
  229. require.Equal(t, "ben", ben.Name)
  230. require.True(t, strings.HasPrefix(ben.Hash, "$2a$04$")) // Min cost for testing
  231. require.Equal(t, RoleUser, ben.Role)
  232. benGrants, err := a.Grants("ben")
  233. require.Nil(t, err)
  234. require.Equal(t, []Grant{
  235. {"everyonewrite", PermissionDenyAll},
  236. {"mytopic", PermissionReadWrite},
  237. {"writeme", PermissionWrite},
  238. {"readme", PermissionRead},
  239. }, benGrants)
  240. everyone, err := a.User(Everyone)
  241. require.Nil(t, err)
  242. require.Equal(t, "*", everyone.Name)
  243. require.Equal(t, "", everyone.Hash)
  244. require.Equal(t, RoleAnonymous, everyone.Role)
  245. everyoneGrants, err := a.Grants(Everyone)
  246. require.Nil(t, err)
  247. require.Equal(t, []Grant{
  248. {"everyonewrite", PermissionReadWrite},
  249. {"announcements", PermissionRead},
  250. }, everyoneGrants)
  251. // Ben: Before revoking
  252. require.Nil(t, a.AllowAccess("ben", "mytopic", PermissionReadWrite)) // Overwrite!
  253. require.Nil(t, a.AllowAccess("ben", "readme", PermissionRead))
  254. require.Nil(t, a.AllowAccess("ben", "writeme", PermissionWrite))
  255. require.Nil(t, a.Authorize(ben, "mytopic", PermissionRead))
  256. require.Nil(t, a.Authorize(ben, "mytopic", PermissionWrite))
  257. require.Nil(t, a.Authorize(ben, "readme", PermissionRead))
  258. require.Nil(t, a.Authorize(ben, "writeme", PermissionWrite))
  259. // Revoke access for "ben" to "mytopic", then check again
  260. require.Nil(t, a.ResetAccess("ben", "mytopic"))
  261. require.Equal(t, ErrUnauthorized, a.Authorize(ben, "mytopic", PermissionWrite)) // Revoked
  262. require.Equal(t, ErrUnauthorized, a.Authorize(ben, "mytopic", PermissionRead)) // Revoked
  263. require.Nil(t, a.Authorize(ben, "readme", PermissionRead)) // Unchanged
  264. require.Nil(t, a.Authorize(ben, "writeme", PermissionWrite)) // Unchanged
  265. // Revoke rest of the access
  266. require.Nil(t, a.ResetAccess("ben", ""))
  267. require.Equal(t, ErrUnauthorized, a.Authorize(ben, "readme", PermissionRead)) // Revoked
  268. require.Equal(t, ErrUnauthorized, a.Authorize(ben, "wrtiteme", PermissionWrite)) // Revoked
  269. // User list
  270. users, err := a.Users()
  271. require.Nil(t, err)
  272. require.Equal(t, 3, len(users))
  273. require.Equal(t, "phil", users[0].Name)
  274. require.Equal(t, "ben", users[1].Name)
  275. require.Equal(t, "*", users[2].Name)
  276. // Remove user
  277. require.Nil(t, a.RemoveUser("ben"))
  278. _, err = a.User("ben")
  279. require.Equal(t, ErrUserNotFound, err)
  280. users, err = a.Users()
  281. require.Nil(t, err)
  282. require.Equal(t, 2, len(users))
  283. require.Equal(t, "phil", users[0].Name)
  284. require.Equal(t, "*", users[1].Name)
  285. }
  286. func TestManager_ChangePassword(t *testing.T) {
  287. a := newTestManager(t, PermissionDenyAll)
  288. require.Nil(t, a.AddUser("phil", "phil", RoleAdmin, false))
  289. require.Nil(t, a.AddUser("jane", "$2b$10$OyqU72muEy7VMd1SAU2Iru5IbeSMgrtCGHu/fWLmxL1MwlijQXWbG", RoleUser, true))
  290. _, err := a.Authenticate("phil", "phil")
  291. require.Nil(t, err)
  292. _, err = a.Authenticate("jane", "jane")
  293. require.Nil(t, err)
  294. require.Nil(t, a.ChangePassword("phil", "newpass", false))
  295. _, err = a.Authenticate("phil", "phil")
  296. require.Equal(t, ErrUnauthenticated, err)
  297. _, err = a.Authenticate("phil", "newpass")
  298. require.Nil(t, err)
  299. require.Nil(t, a.ChangePassword("jane", "$2b$10$CNaCW.q1R431urlbQ5Drh.zl48TiiOeJSmZgfcswkZiPbJGQ1ApSS", true))
  300. _, err = a.Authenticate("jane", "jane")
  301. require.Equal(t, ErrUnauthenticated, err)
  302. _, err = a.Authenticate("jane", "newpass")
  303. require.Nil(t, err)
  304. }
  305. func TestManager_ChangeRole(t *testing.T) {
  306. a := newTestManager(t, PermissionDenyAll)
  307. require.Nil(t, a.AddUser("ben", "ben", RoleUser, false))
  308. require.Nil(t, a.AllowAccess("ben", "mytopic", PermissionReadWrite))
  309. require.Nil(t, a.AllowAccess("ben", "readme", PermissionRead))
  310. ben, err := a.User("ben")
  311. require.Nil(t, err)
  312. require.Equal(t, RoleUser, ben.Role)
  313. benGrants, err := a.Grants("ben")
  314. require.Nil(t, err)
  315. require.Equal(t, 2, len(benGrants))
  316. require.Nil(t, a.ChangeRole("ben", RoleAdmin))
  317. ben, err = a.User("ben")
  318. require.Nil(t, err)
  319. require.Equal(t, RoleAdmin, ben.Role)
  320. benGrants, err = a.Grants("ben")
  321. require.Nil(t, err)
  322. require.Equal(t, 0, len(benGrants))
  323. }
  324. func TestManager_Reservations(t *testing.T) {
  325. a := newTestManager(t, PermissionDenyAll)
  326. require.Nil(t, a.AddUser("phil", "phil", RoleUser, false))
  327. require.Nil(t, a.AddUser("ben", "ben", RoleUser, false))
  328. require.Nil(t, a.AddReservation("ben", "ztopic_", PermissionDenyAll))
  329. require.Nil(t, a.AddReservation("ben", "readme", PermissionRead))
  330. require.Nil(t, a.AllowAccess("ben", "something-else", PermissionRead))
  331. reservations, err := a.Reservations("ben")
  332. require.Nil(t, err)
  333. require.Equal(t, 2, len(reservations))
  334. require.Equal(t, Reservation{
  335. Topic: "readme",
  336. Owner: PermissionReadWrite,
  337. Everyone: PermissionRead,
  338. }, reservations[0])
  339. require.Equal(t, Reservation{
  340. Topic: "ztopic_",
  341. Owner: PermissionReadWrite,
  342. Everyone: PermissionDenyAll,
  343. }, reservations[1])
  344. b, err := a.HasReservation("ben", "readme")
  345. require.Nil(t, err)
  346. require.True(t, b)
  347. b, err = a.HasReservation("ben", "ztopic_")
  348. require.Nil(t, err)
  349. require.True(t, b)
  350. b, err = a.HasReservation("ben", "ztopicX") // _ != X (used to be a SQL wildcard issue)
  351. require.Nil(t, err)
  352. require.False(t, b)
  353. b, err = a.HasReservation("notben", "readme")
  354. require.Nil(t, err)
  355. require.False(t, b)
  356. b, err = a.HasReservation("ben", "something-else")
  357. require.Nil(t, err)
  358. require.False(t, b)
  359. count, err := a.ReservationsCount("ben")
  360. require.Nil(t, err)
  361. require.Equal(t, int64(2), count)
  362. count, err = a.ReservationsCount("phil")
  363. require.Nil(t, err)
  364. require.Equal(t, int64(0), count)
  365. err = a.AllowReservation("phil", "readme")
  366. require.Equal(t, errTopicOwnedByOthers, err)
  367. err = a.AllowReservation("phil", "ztopic_")
  368. require.Equal(t, errTopicOwnedByOthers, err)
  369. err = a.AllowReservation("phil", "ztopicX")
  370. require.Nil(t, err)
  371. err = a.AllowReservation("phil", "not-reserved")
  372. require.Nil(t, err)
  373. // Now remove them again
  374. require.Nil(t, a.RemoveReservations("ben", "ztopic_", "readme"))
  375. count, err = a.ReservationsCount("ben")
  376. require.Nil(t, err)
  377. require.Equal(t, int64(0), count)
  378. }
  379. func TestManager_ChangeRoleFromTierUserToAdmin(t *testing.T) {
  380. a := newTestManager(t, PermissionDenyAll)
  381. require.Nil(t, a.AddTier(&Tier{
  382. Code: "pro",
  383. Name: "ntfy Pro",
  384. StripeMonthlyPriceID: "price123",
  385. MessageLimit: 5_000,
  386. MessageExpiryDuration: 3 * 24 * time.Hour,
  387. EmailLimit: 50,
  388. ReservationLimit: 5,
  389. AttachmentFileSizeLimit: 52428800,
  390. AttachmentTotalSizeLimit: 524288000,
  391. AttachmentExpiryDuration: 24 * time.Hour,
  392. }))
  393. require.Nil(t, a.AddUser("ben", "ben", RoleUser, false))
  394. require.Nil(t, a.ChangeTier("ben", "pro"))
  395. require.Nil(t, a.AddReservation("ben", "mytopic", PermissionDenyAll))
  396. ben, err := a.User("ben")
  397. require.Nil(t, err)
  398. require.Equal(t, RoleUser, ben.Role)
  399. require.Equal(t, "pro", ben.Tier.Code)
  400. require.Equal(t, int64(5000), ben.Tier.MessageLimit)
  401. require.Equal(t, 3*24*time.Hour, ben.Tier.MessageExpiryDuration)
  402. require.Equal(t, int64(50), ben.Tier.EmailLimit)
  403. require.Equal(t, int64(5), ben.Tier.ReservationLimit)
  404. require.Equal(t, int64(52428800), ben.Tier.AttachmentFileSizeLimit)
  405. require.Equal(t, int64(524288000), ben.Tier.AttachmentTotalSizeLimit)
  406. require.Equal(t, 24*time.Hour, ben.Tier.AttachmentExpiryDuration)
  407. benGrants, err := a.Grants("ben")
  408. require.Nil(t, err)
  409. require.Equal(t, 1, len(benGrants))
  410. require.Equal(t, PermissionReadWrite, benGrants[0].Allow)
  411. everyoneGrants, err := a.Grants(Everyone)
  412. require.Nil(t, err)
  413. require.Equal(t, 1, len(everyoneGrants))
  414. require.Equal(t, PermissionDenyAll, everyoneGrants[0].Allow)
  415. benReservations, err := a.Reservations("ben")
  416. require.Nil(t, err)
  417. require.Equal(t, 1, len(benReservations))
  418. require.Equal(t, "mytopic", benReservations[0].Topic)
  419. require.Equal(t, PermissionReadWrite, benReservations[0].Owner)
  420. require.Equal(t, PermissionDenyAll, benReservations[0].Everyone)
  421. // Switch to admin, this should remove all grants and owned ACL entries
  422. require.Nil(t, a.ChangeRole("ben", RoleAdmin))
  423. benGrants, err = a.Grants("ben")
  424. require.Nil(t, err)
  425. require.Equal(t, 0, len(benGrants))
  426. everyoneGrants, err = a.Grants(Everyone)
  427. require.Nil(t, err)
  428. require.Equal(t, 0, len(everyoneGrants))
  429. }
  430. func TestManager_Token_Valid(t *testing.T) {
  431. a := newTestManager(t, PermissionDenyAll)
  432. require.Nil(t, a.AddUser("ben", "ben", RoleUser, false))
  433. u, err := a.User("ben")
  434. require.Nil(t, err)
  435. // Create token for user
  436. token, err := a.CreateToken(u.ID, "some label", time.Now().Add(72*time.Hour), netip.IPv4Unspecified())
  437. require.Nil(t, err)
  438. require.NotEmpty(t, token.Value)
  439. require.Equal(t, "some label", token.Label)
  440. require.True(t, time.Now().Add(71*time.Hour).Unix() < token.Expires.Unix())
  441. u2, err := a.AuthenticateToken(token.Value)
  442. require.Nil(t, err)
  443. require.Equal(t, u.Name, u2.Name)
  444. require.Equal(t, token.Value, u2.Token)
  445. token2, err := a.Token(u.ID, token.Value)
  446. require.Nil(t, err)
  447. require.Equal(t, token.Value, token2.Value)
  448. require.Equal(t, "some label", token2.Label)
  449. tokens, err := a.Tokens(u.ID)
  450. require.Nil(t, err)
  451. require.Equal(t, 1, len(tokens))
  452. require.Equal(t, "some label", tokens[0].Label)
  453. tokens, err = a.Tokens("u_notauser")
  454. require.Nil(t, err)
  455. require.Equal(t, 0, len(tokens))
  456. // Remove token and auth again
  457. require.Nil(t, a.RemoveToken(u2.ID, u2.Token))
  458. u3, err := a.AuthenticateToken(token.Value)
  459. require.Equal(t, ErrUnauthenticated, err)
  460. require.Nil(t, u3)
  461. tokens, err = a.Tokens(u.ID)
  462. require.Nil(t, err)
  463. require.Equal(t, 0, len(tokens))
  464. }
  465. func TestManager_Token_Invalid(t *testing.T) {
  466. a := newTestManager(t, PermissionDenyAll)
  467. require.Nil(t, a.AddUser("ben", "ben", RoleUser, false))
  468. u, err := a.AuthenticateToken(strings.Repeat("x", 32)) // 32 == token length
  469. require.Nil(t, u)
  470. require.Equal(t, ErrUnauthenticated, err)
  471. u, err = a.AuthenticateToken("not long enough anyway")
  472. require.Nil(t, u)
  473. require.Equal(t, ErrUnauthenticated, err)
  474. }
  475. func TestManager_Token_NotFound(t *testing.T) {
  476. a := newTestManager(t, PermissionDenyAll)
  477. _, err := a.Token("u_bla", "notfound")
  478. require.Equal(t, ErrTokenNotFound, err)
  479. }
  480. func TestManager_Token_Expire(t *testing.T) {
  481. a := newTestManager(t, PermissionDenyAll)
  482. require.Nil(t, a.AddUser("ben", "ben", RoleUser, false))
  483. u, err := a.User("ben")
  484. require.Nil(t, err)
  485. // Create tokens for user
  486. token1, err := a.CreateToken(u.ID, "", time.Now().Add(72*time.Hour), netip.IPv4Unspecified())
  487. require.Nil(t, err)
  488. require.NotEmpty(t, token1.Value)
  489. require.True(t, time.Now().Add(71*time.Hour).Unix() < token1.Expires.Unix())
  490. token2, err := a.CreateToken(u.ID, "", time.Now().Add(72*time.Hour), netip.IPv4Unspecified())
  491. require.Nil(t, err)
  492. require.NotEmpty(t, token2.Value)
  493. require.NotEqual(t, token1.Value, token2.Value)
  494. require.True(t, time.Now().Add(71*time.Hour).Unix() < token2.Expires.Unix())
  495. // See that tokens work
  496. _, err = a.AuthenticateToken(token1.Value)
  497. require.Nil(t, err)
  498. _, err = a.AuthenticateToken(token2.Value)
  499. require.Nil(t, err)
  500. // Modify token expiration in database
  501. _, err = a.db.Exec("UPDATE user_token SET expires = 1 WHERE token = ?", token1.Value)
  502. require.Nil(t, err)
  503. // Now token1 shouldn't work anymore
  504. _, err = a.AuthenticateToken(token1.Value)
  505. require.Equal(t, ErrUnauthenticated, err)
  506. result, err := a.db.Query("SELECT * from user_token WHERE token = ?", token1.Value)
  507. require.Nil(t, err)
  508. require.True(t, result.Next()) // Still a matching row
  509. require.Nil(t, result.Close())
  510. // Expire tokens and check database rows
  511. require.Nil(t, a.RemoveExpiredTokens())
  512. result, err = a.db.Query("SELECT * from user_token WHERE token = ?", token1.Value)
  513. require.Nil(t, err)
  514. require.False(t, result.Next()) // No matching row!
  515. require.Nil(t, result.Close())
  516. }
  517. func TestManager_Token_Extend(t *testing.T) {
  518. a := newTestManager(t, PermissionDenyAll)
  519. require.Nil(t, a.AddUser("ben", "ben", RoleUser, false))
  520. // Try to extend token for user without token
  521. u, err := a.User("ben")
  522. require.Nil(t, err)
  523. _, err = a.ChangeToken(u.ID, u.Token, util.String("some label"), util.Time(time.Now().Add(time.Hour)))
  524. require.Equal(t, errNoTokenProvided, err)
  525. // Create token for user
  526. token, err := a.CreateToken(u.ID, "", time.Now().Add(72*time.Hour), netip.IPv4Unspecified())
  527. require.Nil(t, err)
  528. require.NotEmpty(t, token.Value)
  529. userWithToken, err := a.AuthenticateToken(token.Value)
  530. require.Nil(t, err)
  531. extendedToken, err := a.ChangeToken(userWithToken.ID, userWithToken.Token, util.String("changed label"), util.Time(time.Now().Add(100*time.Hour)))
  532. require.Nil(t, err)
  533. require.Equal(t, token.Value, extendedToken.Value)
  534. require.Equal(t, "changed label", extendedToken.Label)
  535. require.True(t, token.Expires.Unix() < extendedToken.Expires.Unix())
  536. require.True(t, time.Now().Add(99*time.Hour).Unix() < extendedToken.Expires.Unix())
  537. }
  538. func TestManager_Token_MaxCount_AutoDelete(t *testing.T) {
  539. // Tests that tokens are automatically deleted when the maximum number of tokens is reached
  540. a := newTestManager(t, PermissionDenyAll)
  541. require.Nil(t, a.AddUser("ben", "ben", RoleUser, false))
  542. require.Nil(t, a.AddUser("phil", "phil", RoleUser, false))
  543. ben, err := a.User("ben")
  544. require.Nil(t, err)
  545. phil, err := a.User("phil")
  546. require.Nil(t, err)
  547. // Create 2 tokens for phil
  548. philTokens := make([]string, 0)
  549. token, err := a.CreateToken(phil.ID, "", time.Now().Add(72*time.Hour), netip.IPv4Unspecified())
  550. require.Nil(t, err)
  551. require.NotEmpty(t, token.Value)
  552. philTokens = append(philTokens, token.Value)
  553. token, err = a.CreateToken(phil.ID, "", time.Unix(0, 0), netip.IPv4Unspecified())
  554. require.Nil(t, err)
  555. require.NotEmpty(t, token.Value)
  556. philTokens = append(philTokens, token.Value)
  557. // Create 62 tokens for ben (only 60 allowed!)
  558. baseTime := time.Now().Add(24 * time.Hour)
  559. benTokens := make([]string, 0)
  560. for i := 0; i < 62; i++ { //
  561. token, err := a.CreateToken(ben.ID, "", time.Now().Add(72*time.Hour), netip.IPv4Unspecified())
  562. require.Nil(t, err)
  563. require.NotEmpty(t, token.Value)
  564. benTokens = append(benTokens, token.Value)
  565. // Manually modify expiry date to avoid sorting issues (this is a hack)
  566. _, err = a.db.Exec(`UPDATE user_token SET expires=? WHERE token=?`, baseTime.Add(time.Duration(i)*time.Minute).Unix(), token.Value)
  567. require.Nil(t, err)
  568. }
  569. // Ben: The first 2 tokens should have been wiped and should not work anymore!
  570. _, err = a.AuthenticateToken(benTokens[0])
  571. require.Equal(t, ErrUnauthenticated, err)
  572. _, err = a.AuthenticateToken(benTokens[1])
  573. require.Equal(t, ErrUnauthenticated, err)
  574. // Ben: The other tokens should still work
  575. for i := 2; i < 62; i++ {
  576. userWithToken, err := a.AuthenticateToken(benTokens[i])
  577. require.Nil(t, err, "token[%d]=%s failed", i, benTokens[i])
  578. require.Equal(t, "ben", userWithToken.Name)
  579. require.Equal(t, benTokens[i], userWithToken.Token)
  580. }
  581. // Phil: All tokens should still work
  582. for i := 0; i < 2; i++ {
  583. userWithToken, err := a.AuthenticateToken(philTokens[i])
  584. require.Nil(t, err, "token[%d]=%s failed", i, philTokens[i])
  585. require.Equal(t, "phil", userWithToken.Name)
  586. require.Equal(t, philTokens[i], userWithToken.Token)
  587. }
  588. var benCount int
  589. rows, err := a.db.Query(`SELECT COUNT(*) FROM user_token WHERE user_id=?`, ben.ID)
  590. require.Nil(t, err)
  591. require.True(t, rows.Next())
  592. require.Nil(t, rows.Scan(&benCount))
  593. require.Equal(t, 60, benCount)
  594. var philCount int
  595. rows, err = a.db.Query(`SELECT COUNT(*) FROM user_token WHERE user_id=?`, phil.ID)
  596. require.Nil(t, err)
  597. require.True(t, rows.Next())
  598. require.Nil(t, rows.Scan(&philCount))
  599. require.Equal(t, 2, philCount)
  600. }
  601. func TestManager_EnqueueStats_ResetStats(t *testing.T) {
  602. a, err := NewManager(filepath.Join(t.TempDir(), "db"), "", PermissionReadWrite, bcrypt.MinCost, 1500*time.Millisecond)
  603. require.Nil(t, err)
  604. require.Nil(t, a.AddUser("ben", "ben", RoleUser, false))
  605. // Baseline: No messages or emails
  606. u, err := a.User("ben")
  607. require.Nil(t, err)
  608. require.Equal(t, int64(0), u.Stats.Messages)
  609. require.Equal(t, int64(0), u.Stats.Emails)
  610. a.EnqueueUserStats(u.ID, &Stats{
  611. Messages: 11,
  612. Emails: 2,
  613. })
  614. // Still no change, because it's queued asynchronously
  615. u, err = a.User("ben")
  616. require.Nil(t, err)
  617. require.Equal(t, int64(0), u.Stats.Messages)
  618. require.Equal(t, int64(0), u.Stats.Emails)
  619. // After 2 seconds they should be persisted
  620. time.Sleep(2 * time.Second)
  621. u, err = a.User("ben")
  622. require.Nil(t, err)
  623. require.Equal(t, int64(11), u.Stats.Messages)
  624. require.Equal(t, int64(2), u.Stats.Emails)
  625. // Now reset stats (enqueued stats will be thrown out)
  626. a.EnqueueUserStats(u.ID, &Stats{
  627. Messages: 99,
  628. Emails: 23,
  629. })
  630. require.Nil(t, a.ResetStats())
  631. u, err = a.User("ben")
  632. require.Nil(t, err)
  633. require.Equal(t, int64(0), u.Stats.Messages)
  634. require.Equal(t, int64(0), u.Stats.Emails)
  635. }
  636. func TestManager_EnqueueTokenUpdate(t *testing.T) {
  637. a, err := NewManager(filepath.Join(t.TempDir(), "db"), "", PermissionReadWrite, bcrypt.MinCost, 500*time.Millisecond)
  638. require.Nil(t, err)
  639. require.Nil(t, a.AddUser("ben", "ben", RoleUser, false))
  640. // Create user and token
  641. u, err := a.User("ben")
  642. require.Nil(t, err)
  643. token, err := a.CreateToken(u.ID, "", time.Now().Add(time.Hour), netip.IPv4Unspecified())
  644. require.Nil(t, err)
  645. // Queue token update
  646. a.EnqueueTokenUpdate(token.Value, &TokenUpdate{
  647. LastAccess: time.Unix(111, 0).UTC(),
  648. LastOrigin: netip.MustParseAddr("1.2.3.3"),
  649. })
  650. // Token has not changed yet.
  651. token2, err := a.Token(u.ID, token.Value)
  652. require.Nil(t, err)
  653. require.Equal(t, token.LastAccess.Unix(), token2.LastAccess.Unix())
  654. require.Equal(t, token.LastOrigin, token2.LastOrigin)
  655. // After a second or so they should be persisted
  656. time.Sleep(time.Second)
  657. token3, err := a.Token(u.ID, token.Value)
  658. require.Nil(t, err)
  659. require.Equal(t, time.Unix(111, 0).UTC().Unix(), token3.LastAccess.Unix())
  660. require.Equal(t, netip.MustParseAddr("1.2.3.3"), token3.LastOrigin)
  661. }
  662. func TestManager_ChangeSettings(t *testing.T) {
  663. a, err := NewManager(filepath.Join(t.TempDir(), "db"), "", PermissionReadWrite, bcrypt.MinCost, 1500*time.Millisecond)
  664. require.Nil(t, err)
  665. require.Nil(t, a.AddUser("ben", "ben", RoleUser, false))
  666. // No settings
  667. u, err := a.User("ben")
  668. require.Nil(t, err)
  669. require.Nil(t, u.Prefs.Subscriptions)
  670. require.Nil(t, u.Prefs.Notification)
  671. require.Nil(t, u.Prefs.Language)
  672. // Save with new settings
  673. prefs := &Prefs{
  674. Language: util.String("de"),
  675. Notification: &NotificationPrefs{
  676. Sound: util.String("ding"),
  677. MinPriority: util.Int(2),
  678. },
  679. Subscriptions: []*Subscription{
  680. {
  681. BaseURL: "https://ntfy.sh",
  682. Topic: "mytopic",
  683. DisplayName: util.String("My Topic"),
  684. },
  685. },
  686. }
  687. require.Nil(t, a.ChangeSettings(u.ID, prefs))
  688. // Read again
  689. u, err = a.User("ben")
  690. require.Nil(t, err)
  691. require.Equal(t, util.String("de"), u.Prefs.Language)
  692. require.Equal(t, util.String("ding"), u.Prefs.Notification.Sound)
  693. require.Equal(t, util.Int(2), u.Prefs.Notification.MinPriority)
  694. require.Nil(t, u.Prefs.Notification.DeleteAfter)
  695. require.Equal(t, "https://ntfy.sh", u.Prefs.Subscriptions[0].BaseURL)
  696. require.Equal(t, "mytopic", u.Prefs.Subscriptions[0].Topic)
  697. require.Equal(t, util.String("My Topic"), u.Prefs.Subscriptions[0].DisplayName)
  698. }
  699. func TestManager_Tier_Create_Update_List_Delete(t *testing.T) {
  700. a := newTestManager(t, PermissionDenyAll)
  701. // Create tier and user
  702. require.Nil(t, a.AddTier(&Tier{
  703. Code: "supporter",
  704. Name: "Supporter",
  705. MessageLimit: 1,
  706. MessageExpiryDuration: time.Second,
  707. EmailLimit: 1,
  708. ReservationLimit: 1,
  709. AttachmentFileSizeLimit: 1,
  710. AttachmentTotalSizeLimit: 1,
  711. AttachmentExpiryDuration: time.Second,
  712. AttachmentBandwidthLimit: 1,
  713. StripeMonthlyPriceID: "price_1",
  714. }))
  715. require.Nil(t, a.AddTier(&Tier{
  716. Code: "pro",
  717. Name: "Pro",
  718. MessageLimit: 123,
  719. MessageExpiryDuration: 86400 * time.Second,
  720. EmailLimit: 32,
  721. ReservationLimit: 2,
  722. AttachmentFileSizeLimit: 1231231,
  723. AttachmentTotalSizeLimit: 123123,
  724. AttachmentExpiryDuration: 10800 * time.Second,
  725. AttachmentBandwidthLimit: 21474836480,
  726. StripeMonthlyPriceID: "price_2",
  727. }))
  728. require.Nil(t, a.AddUser("phil", "phil", RoleUser, false))
  729. require.Nil(t, a.ChangeTier("phil", "pro"))
  730. ti, err := a.Tier("pro")
  731. require.Nil(t, err)
  732. u, err := a.User("phil")
  733. require.Nil(t, err)
  734. // These are populated by different SQL queries
  735. require.Equal(t, ti, u.Tier)
  736. // Fields
  737. require.True(t, strings.HasPrefix(ti.ID, "ti_"))
  738. require.Equal(t, "pro", ti.Code)
  739. require.Equal(t, "Pro", ti.Name)
  740. require.Equal(t, int64(123), ti.MessageLimit)
  741. require.Equal(t, 86400*time.Second, ti.MessageExpiryDuration)
  742. require.Equal(t, int64(32), ti.EmailLimit)
  743. require.Equal(t, int64(2), ti.ReservationLimit)
  744. require.Equal(t, int64(1231231), ti.AttachmentFileSizeLimit)
  745. require.Equal(t, int64(123123), ti.AttachmentTotalSizeLimit)
  746. require.Equal(t, 10800*time.Second, ti.AttachmentExpiryDuration)
  747. require.Equal(t, int64(21474836480), ti.AttachmentBandwidthLimit)
  748. require.Equal(t, "price_2", ti.StripeMonthlyPriceID)
  749. // Update tier
  750. ti.EmailLimit = 999999
  751. require.Nil(t, a.UpdateTier(ti))
  752. // List tiers
  753. tiers, err := a.Tiers()
  754. require.Nil(t, err)
  755. require.Equal(t, 2, len(tiers))
  756. ti = tiers[0]
  757. require.Equal(t, "supporter", ti.Code)
  758. require.Equal(t, "Supporter", ti.Name)
  759. require.Equal(t, int64(1), ti.MessageLimit)
  760. require.Equal(t, time.Second, ti.MessageExpiryDuration)
  761. require.Equal(t, int64(1), ti.EmailLimit)
  762. require.Equal(t, int64(1), ti.ReservationLimit)
  763. require.Equal(t, int64(1), ti.AttachmentFileSizeLimit)
  764. require.Equal(t, int64(1), ti.AttachmentTotalSizeLimit)
  765. require.Equal(t, time.Second, ti.AttachmentExpiryDuration)
  766. require.Equal(t, int64(1), ti.AttachmentBandwidthLimit)
  767. require.Equal(t, "price_1", ti.StripeMonthlyPriceID)
  768. ti = tiers[1]
  769. require.Equal(t, "pro", ti.Code)
  770. require.Equal(t, "Pro", ti.Name)
  771. require.Equal(t, int64(123), ti.MessageLimit)
  772. require.Equal(t, 86400*time.Second, ti.MessageExpiryDuration)
  773. require.Equal(t, int64(999999), ti.EmailLimit) // Updatedd!
  774. require.Equal(t, int64(2), ti.ReservationLimit)
  775. require.Equal(t, int64(1231231), ti.AttachmentFileSizeLimit)
  776. require.Equal(t, int64(123123), ti.AttachmentTotalSizeLimit)
  777. require.Equal(t, 10800*time.Second, ti.AttachmentExpiryDuration)
  778. require.Equal(t, int64(21474836480), ti.AttachmentBandwidthLimit)
  779. require.Equal(t, "price_2", ti.StripeMonthlyPriceID)
  780. ti, err = a.TierByStripePrice("price_1")
  781. require.Nil(t, err)
  782. require.Equal(t, "supporter", ti.Code)
  783. require.Equal(t, "Supporter", ti.Name)
  784. require.Equal(t, int64(1), ti.MessageLimit)
  785. require.Equal(t, time.Second, ti.MessageExpiryDuration)
  786. require.Equal(t, int64(1), ti.EmailLimit)
  787. require.Equal(t, int64(1), ti.ReservationLimit)
  788. require.Equal(t, int64(1), ti.AttachmentFileSizeLimit)
  789. require.Equal(t, int64(1), ti.AttachmentTotalSizeLimit)
  790. require.Equal(t, time.Second, ti.AttachmentExpiryDuration)
  791. require.Equal(t, int64(1), ti.AttachmentBandwidthLimit)
  792. require.Equal(t, "price_1", ti.StripeMonthlyPriceID)
  793. // Cannot remove tier, since user has this tier
  794. require.Error(t, a.RemoveTier("pro"))
  795. // CAN remove this tier
  796. require.Nil(t, a.RemoveTier("supporter"))
  797. tiers, err = a.Tiers()
  798. require.Nil(t, err)
  799. require.Equal(t, 1, len(tiers))
  800. require.Equal(t, "pro", tiers[0].Code)
  801. require.Equal(t, "pro", tiers[0].Code)
  802. }
  803. func TestAccount_Tier_Create_With_ID(t *testing.T) {
  804. a := newTestManager(t, PermissionDenyAll)
  805. require.Nil(t, a.AddTier(&Tier{
  806. ID: "ti_123",
  807. Code: "pro",
  808. }))
  809. ti, err := a.Tier("pro")
  810. require.Nil(t, err)
  811. require.Equal(t, "ti_123", ti.ID)
  812. }
  813. func TestManager_Tier_Change_And_Reset(t *testing.T) {
  814. a := newTestManager(t, PermissionDenyAll)
  815. // Create tier and user
  816. require.Nil(t, a.AddTier(&Tier{
  817. Code: "supporter",
  818. Name: "Supporter",
  819. ReservationLimit: 3,
  820. }))
  821. require.Nil(t, a.AddTier(&Tier{
  822. Code: "pro",
  823. Name: "Pro",
  824. ReservationLimit: 4,
  825. }))
  826. require.Nil(t, a.AddUser("phil", "phil", RoleUser, false))
  827. require.Nil(t, a.ChangeTier("phil", "pro"))
  828. // Add 10 reservations (pro tier allows that)
  829. for i := 0; i < 4; i++ {
  830. require.Nil(t, a.AddReservation("phil", fmt.Sprintf("topic%d", i), PermissionWrite))
  831. }
  832. // Downgrading will not work (too many reservations)
  833. require.Equal(t, ErrTooManyReservations, a.ChangeTier("phil", "supporter"))
  834. // Downgrade after removing a reservation
  835. require.Nil(t, a.RemoveReservations("phil", "topic0"))
  836. require.Nil(t, a.ChangeTier("phil", "supporter"))
  837. // Resetting will not work (too many reservations)
  838. require.Equal(t, ErrTooManyReservations, a.ResetTier("phil"))
  839. // Resetting after removing all reservations
  840. require.Nil(t, a.RemoveReservations("phil", "topic1", "topic2", "topic3"))
  841. require.Nil(t, a.ResetTier("phil"))
  842. }
  843. func TestUser_PhoneNumberAddListRemove(t *testing.T) {
  844. a := newTestManager(t, PermissionDenyAll)
  845. require.Nil(t, a.AddUser("phil", "phil", RoleUser, false))
  846. phil, err := a.User("phil")
  847. require.Nil(t, err)
  848. require.Nil(t, a.AddPhoneNumber(phil.ID, "+1234567890"))
  849. phoneNumbers, err := a.PhoneNumbers(phil.ID)
  850. require.Nil(t, err)
  851. require.Equal(t, 1, len(phoneNumbers))
  852. require.Equal(t, "+1234567890", phoneNumbers[0])
  853. require.Nil(t, a.RemovePhoneNumber(phil.ID, "+1234567890"))
  854. phoneNumbers, err = a.PhoneNumbers(phil.ID)
  855. require.Nil(t, err)
  856. require.Equal(t, 0, len(phoneNumbers))
  857. // Paranoia check: We do NOT want to keep phone numbers in there
  858. rows, err := a.db.Query(`SELECT * FROM user_phone`)
  859. require.Nil(t, err)
  860. require.False(t, rows.Next())
  861. require.Nil(t, rows.Close())
  862. }
  863. func TestUser_PhoneNumberAdd_Multiple_Users_Same_Number(t *testing.T) {
  864. a := newTestManager(t, PermissionDenyAll)
  865. require.Nil(t, a.AddUser("phil", "phil", RoleUser, false))
  866. require.Nil(t, a.AddUser("ben", "ben", RoleUser, false))
  867. phil, err := a.User("phil")
  868. require.Nil(t, err)
  869. ben, err := a.User("ben")
  870. require.Nil(t, err)
  871. require.Nil(t, a.AddPhoneNumber(phil.ID, "+1234567890"))
  872. require.Nil(t, a.AddPhoneNumber(ben.ID, "+1234567890"))
  873. }
  874. func TestManager_Topic_Wildcard_With_Asterisk_Underscore(t *testing.T) {
  875. f := filepath.Join(t.TempDir(), "user.db")
  876. a := newTestManagerFromFile(t, f, "", PermissionDenyAll, DefaultUserPasswordBcryptCost, DefaultUserStatsQueueWriterInterval)
  877. require.Nil(t, a.AllowAccess(Everyone, "*_", PermissionRead))
  878. require.Nil(t, a.AllowAccess(Everyone, "__*_", PermissionRead))
  879. require.Nil(t, a.Authorize(nil, "allowed_", PermissionRead))
  880. require.Nil(t, a.Authorize(nil, "__allowed_", PermissionRead))
  881. require.Nil(t, a.Authorize(nil, "_allowed_", PermissionRead)) // The "%" in "%\_" matches the first "_"
  882. require.Equal(t, ErrUnauthorized, a.Authorize(nil, "notallowed", PermissionRead))
  883. require.Equal(t, ErrUnauthorized, a.Authorize(nil, "_notallowed", PermissionRead))
  884. require.Equal(t, ErrUnauthorized, a.Authorize(nil, "__notallowed", PermissionRead))
  885. }
  886. func TestManager_Topic_Wildcard_With_Underscore(t *testing.T) {
  887. f := filepath.Join(t.TempDir(), "user.db")
  888. a := newTestManagerFromFile(t, f, "", PermissionDenyAll, DefaultUserPasswordBcryptCost, DefaultUserStatsQueueWriterInterval)
  889. require.Nil(t, a.AllowAccess(Everyone, "mytopic_", PermissionReadWrite))
  890. require.Nil(t, a.Authorize(nil, "mytopic_", PermissionRead))
  891. require.Nil(t, a.Authorize(nil, "mytopic_", PermissionWrite))
  892. require.Equal(t, ErrUnauthorized, a.Authorize(nil, "mytopicX", PermissionRead))
  893. require.Equal(t, ErrUnauthorized, a.Authorize(nil, "mytopicX", PermissionWrite))
  894. }
  895. func TestToFromSQLWildcard(t *testing.T) {
  896. require.Equal(t, "up%", toSQLWildcard("up*"))
  897. require.Equal(t, "up\\_%", toSQLWildcard("up_*"))
  898. require.Equal(t, "foo", toSQLWildcard("foo"))
  899. require.Equal(t, "up*", fromSQLWildcard("up%"))
  900. require.Equal(t, "up_*", fromSQLWildcard("up\\_%"))
  901. require.Equal(t, "foo", fromSQLWildcard("foo"))
  902. require.Equal(t, "up*", fromSQLWildcard(toSQLWildcard("up*")))
  903. require.Equal(t, "up_*", fromSQLWildcard(toSQLWildcard("up_*")))
  904. require.Equal(t, "foo", fromSQLWildcard(toSQLWildcard("foo")))
  905. }
  906. func TestMigrationFrom1(t *testing.T) {
  907. filename := filepath.Join(t.TempDir(), "user.db")
  908. db, err := sql.Open("sqlite3", filename)
  909. require.Nil(t, err)
  910. // Create "version 1" schema
  911. _, err = db.Exec(`
  912. BEGIN;
  913. CREATE TABLE IF NOT EXISTS user (
  914. user TEXT NOT NULL PRIMARY KEY,
  915. pass TEXT NOT NULL,
  916. role TEXT NOT NULL
  917. );
  918. CREATE TABLE IF NOT EXISTS access (
  919. user TEXT NOT NULL,
  920. topic TEXT NOT NULL,
  921. read INT NOT NULL,
  922. write INT NOT NULL,
  923. PRIMARY KEY (topic, user)
  924. );
  925. CREATE TABLE IF NOT EXISTS schemaVersion (
  926. id INT PRIMARY KEY,
  927. version INT NOT NULL
  928. );
  929. INSERT INTO schemaVersion (id, version) VALUES (1, 1);
  930. COMMIT;
  931. `)
  932. require.Nil(t, err)
  933. // Insert a bunch of users and ACL entries
  934. _, err = db.Exec(`
  935. BEGIN;
  936. INSERT INTO user (user, pass, role) VALUES ('ben', '$2a$10$EEp6gBheOsqEFsXlo523E.gBVoeg1ytphXiEvTPlNzkenBlHZBPQy', 'user');
  937. INSERT INTO user (user, pass, role) VALUES ('phil', '$2a$10$YLiO8U21sX1uhZamTLJXHuxgVC0Z/GKISibrKCLohPgtG7yIxSk4C', 'admin');
  938. INSERT INTO access (user, topic, read, write) VALUES ('ben', 'stats', 1, 1);
  939. INSERT INTO access (user, topic, read, write) VALUES ('ben', 'secret', 1, 0);
  940. INSERT INTO access (user, topic, read, write) VALUES ('*', 'stats', 1, 0);
  941. COMMIT;
  942. `)
  943. require.Nil(t, err)
  944. // Create manager to trigger migration
  945. a := newTestManagerFromFile(t, filename, "", PermissionDenyAll, bcrypt.MinCost, DefaultUserStatsQueueWriterInterval)
  946. checkSchemaVersion(t, a.db)
  947. users, err := a.Users()
  948. require.Nil(t, err)
  949. require.Equal(t, 3, len(users))
  950. phil, ben, everyone := users[0], users[1], users[2]
  951. philGrants, err := a.Grants("phil")
  952. require.Nil(t, err)
  953. benGrants, err := a.Grants("ben")
  954. require.Nil(t, err)
  955. everyoneGrants, err := a.Grants(Everyone)
  956. require.Nil(t, err)
  957. require.True(t, strings.HasPrefix(phil.ID, "u_"))
  958. require.Equal(t, "phil", phil.Name)
  959. require.Equal(t, RoleAdmin, phil.Role)
  960. require.Equal(t, syncTopicLength, len(phil.SyncTopic))
  961. require.Equal(t, 0, len(philGrants))
  962. require.True(t, strings.HasPrefix(ben.ID, "u_"))
  963. require.NotEqual(t, phil.ID, ben.ID)
  964. require.Equal(t, "ben", ben.Name)
  965. require.Equal(t, RoleUser, ben.Role)
  966. require.Equal(t, syncTopicLength, len(ben.SyncTopic))
  967. require.NotEqual(t, ben.SyncTopic, phil.SyncTopic)
  968. require.Equal(t, 2, len(benGrants))
  969. require.Equal(t, "secret", benGrants[0].TopicPattern)
  970. require.Equal(t, PermissionRead, benGrants[0].Allow)
  971. require.Equal(t, "stats", benGrants[1].TopicPattern)
  972. require.Equal(t, PermissionReadWrite, benGrants[1].Allow)
  973. require.Equal(t, "u_everyone", everyone.ID)
  974. require.Equal(t, Everyone, everyone.Name)
  975. require.Equal(t, RoleAnonymous, everyone.Role)
  976. require.Equal(t, 1, len(everyoneGrants))
  977. require.Equal(t, "stats", everyoneGrants[0].TopicPattern)
  978. require.Equal(t, PermissionRead, everyoneGrants[0].Allow)
  979. }
  980. func TestMigrationFrom4(t *testing.T) {
  981. filename := filepath.Join(t.TempDir(), "user.db")
  982. db, err := sql.Open("sqlite3", filename)
  983. require.Nil(t, err)
  984. // Create "version 4" schema
  985. _, err = db.Exec(`
  986. BEGIN;
  987. CREATE TABLE IF NOT EXISTS tier (
  988. id TEXT PRIMARY KEY,
  989. code TEXT NOT NULL,
  990. name TEXT NOT NULL,
  991. messages_limit INT NOT NULL,
  992. messages_expiry_duration INT NOT NULL,
  993. emails_limit INT NOT NULL,
  994. calls_limit INT NOT NULL,
  995. reservations_limit INT NOT NULL,
  996. attachment_file_size_limit INT NOT NULL,
  997. attachment_total_size_limit INT NOT NULL,
  998. attachment_expiry_duration INT NOT NULL,
  999. attachment_bandwidth_limit INT NOT NULL,
  1000. stripe_monthly_price_id TEXT,
  1001. stripe_yearly_price_id TEXT
  1002. );
  1003. CREATE UNIQUE INDEX idx_tier_code ON tier (code);
  1004. CREATE UNIQUE INDEX idx_tier_stripe_monthly_price_id ON tier (stripe_monthly_price_id);
  1005. CREATE UNIQUE INDEX idx_tier_stripe_yearly_price_id ON tier (stripe_yearly_price_id);
  1006. CREATE TABLE IF NOT EXISTS user (
  1007. id TEXT PRIMARY KEY,
  1008. tier_id TEXT,
  1009. user TEXT NOT NULL,
  1010. pass TEXT NOT NULL,
  1011. role TEXT CHECK (role IN ('anonymous', 'admin', 'user')) NOT NULL,
  1012. prefs JSON NOT NULL DEFAULT '{}',
  1013. sync_topic TEXT NOT NULL,
  1014. stats_messages INT NOT NULL DEFAULT (0),
  1015. stats_emails INT NOT NULL DEFAULT (0),
  1016. stats_calls INT NOT NULL DEFAULT (0),
  1017. stripe_customer_id TEXT,
  1018. stripe_subscription_id TEXT,
  1019. stripe_subscription_status TEXT,
  1020. stripe_subscription_interval TEXT,
  1021. stripe_subscription_paid_until INT,
  1022. stripe_subscription_cancel_at INT,
  1023. created INT NOT NULL,
  1024. deleted INT,
  1025. FOREIGN KEY (tier_id) REFERENCES tier (id)
  1026. );
  1027. CREATE UNIQUE INDEX idx_user ON user (user);
  1028. CREATE UNIQUE INDEX idx_user_stripe_customer_id ON user (stripe_customer_id);
  1029. CREATE UNIQUE INDEX idx_user_stripe_subscription_id ON user (stripe_subscription_id);
  1030. CREATE TABLE IF NOT EXISTS user_access (
  1031. user_id TEXT NOT NULL,
  1032. topic TEXT NOT NULL,
  1033. read INT NOT NULL,
  1034. write INT NOT NULL,
  1035. owner_user_id INT,
  1036. PRIMARY KEY (user_id, topic),
  1037. FOREIGN KEY (user_id) REFERENCES user (id) ON DELETE CASCADE,
  1038. FOREIGN KEY (owner_user_id) REFERENCES user (id) ON DELETE CASCADE
  1039. );
  1040. CREATE TABLE IF NOT EXISTS user_token (
  1041. user_id TEXT NOT NULL,
  1042. token TEXT NOT NULL,
  1043. label TEXT NOT NULL,
  1044. last_access INT NOT NULL,
  1045. last_origin TEXT NOT NULL,
  1046. expires INT NOT NULL,
  1047. PRIMARY KEY (user_id, token),
  1048. FOREIGN KEY (user_id) REFERENCES user (id) ON DELETE CASCADE
  1049. );
  1050. CREATE TABLE IF NOT EXISTS user_phone (
  1051. user_id TEXT NOT NULL,
  1052. phone_number TEXT NOT NULL,
  1053. PRIMARY KEY (user_id, phone_number),
  1054. FOREIGN KEY (user_id) REFERENCES user (id) ON DELETE CASCADE
  1055. );
  1056. CREATE TABLE IF NOT EXISTS schemaVersion (
  1057. id INT PRIMARY KEY,
  1058. version INT NOT NULL
  1059. );
  1060. INSERT INTO user (id, user, pass, role, sync_topic, created)
  1061. VALUES ('u_everyone', '*', '', 'anonymous', '', UNIXEPOCH())
  1062. ON CONFLICT (id) DO NOTHING;
  1063. INSERT INTO schemaVersion (id, version) VALUES (1, 4);
  1064. COMMIT;
  1065. `)
  1066. require.Nil(t, err)
  1067. // Insert a few ACL entries
  1068. _, err = db.Exec(`
  1069. BEGIN;
  1070. INSERT INTO user_access (user_id, topic, read, write) values ('u_everyone', 'mytopic_', 1, 1);
  1071. INSERT INTO user_access (user_id, topic, read, write) values ('u_everyone', 'up%', 1, 1);
  1072. INSERT INTO user_access (user_id, topic, read, write) values ('u_everyone', 'down_%', 1, 1);
  1073. COMMIT;
  1074. `)
  1075. require.Nil(t, err)
  1076. // Create manager to trigger migration
  1077. a := newTestManagerFromFile(t, filename, "", PermissionDenyAll, bcrypt.MinCost, DefaultUserStatsQueueWriterInterval)
  1078. checkSchemaVersion(t, a.db)
  1079. // Add another
  1080. require.Nil(t, a.AllowAccess(Everyone, "left_*", PermissionReadWrite))
  1081. // Check "external view" of grants
  1082. everyoneGrants, err := a.Grants(Everyone)
  1083. require.Nil(t, err)
  1084. require.Equal(t, 4, len(everyoneGrants))
  1085. require.Equal(t, "mytopic_", everyoneGrants[0].TopicPattern)
  1086. require.Equal(t, "down_*", everyoneGrants[1].TopicPattern)
  1087. require.Equal(t, "left_*", everyoneGrants[2].TopicPattern)
  1088. require.Equal(t, "up*", everyoneGrants[3].TopicPattern)
  1089. // Check they are stored correctly in the database
  1090. rows, err := db.Query(`SELECT topic FROM user_access WHERE user_id = 'u_everyone' ORDER BY topic`)
  1091. require.Nil(t, err)
  1092. topicPatterns := make([]string, 0)
  1093. for rows.Next() {
  1094. var topicPattern string
  1095. require.Nil(t, rows.Scan(&topicPattern))
  1096. topicPatterns = append(topicPatterns, topicPattern)
  1097. }
  1098. require.Nil(t, rows.Close())
  1099. require.Equal(t, 4, len(topicPatterns))
  1100. require.Equal(t, "down\\_%", topicPatterns[0])
  1101. require.Equal(t, "left\\_%", topicPatterns[1])
  1102. require.Equal(t, "mytopic\\_", topicPatterns[2])
  1103. require.Equal(t, "up%", topicPatterns[3])
  1104. // Check that ACL works as excepted
  1105. require.Nil(t, a.Authorize(nil, "down_123", PermissionRead))
  1106. require.Equal(t, ErrUnauthorized, a.Authorize(nil, "downX123", PermissionRead))
  1107. require.Nil(t, a.Authorize(nil, "left_abc", PermissionRead))
  1108. require.Equal(t, ErrUnauthorized, a.Authorize(nil, "leftX123", PermissionRead))
  1109. require.Nil(t, a.Authorize(nil, "mytopic_", PermissionRead))
  1110. require.Equal(t, ErrUnauthorized, a.Authorize(nil, "mytopicX", PermissionRead))
  1111. require.Nil(t, a.Authorize(nil, "up123", PermissionRead))
  1112. require.Nil(t, a.Authorize(nil, "up", PermissionRead)) // % matches 0 or more characters
  1113. }
  1114. func checkSchemaVersion(t *testing.T, db *sql.DB) {
  1115. rows, err := db.Query(`SELECT version FROM schemaVersion`)
  1116. require.Nil(t, err)
  1117. require.True(t, rows.Next())
  1118. var schemaVersion int
  1119. require.Nil(t, rows.Scan(&schemaVersion))
  1120. require.Equal(t, currentSchemaVersion, schemaVersion)
  1121. require.Nil(t, rows.Close())
  1122. }
  1123. func newTestManager(t *testing.T, defaultAccess Permission) *Manager {
  1124. return newTestManagerFromFile(t, filepath.Join(t.TempDir(), "user.db"), "", defaultAccess, bcrypt.MinCost, DefaultUserStatsQueueWriterInterval)
  1125. }
  1126. func newTestManagerFromFile(t *testing.T, filename, startupQueries string, defaultAccess Permission, bcryptCost int, statsWriterInterval time.Duration) *Manager {
  1127. a, err := NewManager(filename, startupQueries, defaultAccess, bcryptCost, statsWriterInterval)
  1128. require.Nil(t, err)
  1129. return a
  1130. }