manager_test.go 22 KB

123456789101112131415161718192021222324252627282930313233343536373839404142434445464748495051525354555657585960616263646566676869707172737475767778798081828384858687888990919293949596979899100101102103104105106107108109110111112113114115116117118119120121122123124125126127128129130131132133134135136137138139140141142143144145146147148149150151152153154155156157158159160161162163164165166167168169170171172173174175176177178179180181182183184185186187188189190191192193194195196197198199200201202203204205206207208209210211212213214215216217218219220221222223224225226227228229230231232233234235236237238239240241242243244245246247248249250251252253254255256257258259260261262263264265266267268269270271272273274275276277278279280281282283284285286287288289290291292293294295296297298299300301302303304305306307308309310311312313314315316317318319320321322323324325326327328329330331332333334335336337338339340341342343344345346347348349350351352353354355356357358359360361362363364365366367368369370371372373374375376377378379380381382383384385386387388389390391392393394395396397398399400401402403404405406407408409410411412413414415416417418419420421422423424425426427428429430431432433434435436437438439440441442443444445446447448449450451452453454455456457458459460461462463464465466467468469470471472473474475476477478479480481482483484485486487488489490491492493494495496497498499500501502503504505506507508509510511512513514515516517518519520521522523524525526527528529530531532533534535536537538539540541542543544545546547548549550551552553554555556557558559560561562563564565566567568569570571572573574575576577578579580581582583584585586587588589590591592593594595596597598599600601602603604605606607608609610611612613614615616617618619620621622623624625626627628629630631632633634635636637638639640641642
  1. package user
  2. import (
  3. "database/sql"
  4. "github.com/stretchr/testify/require"
  5. "path/filepath"
  6. "strings"
  7. "testing"
  8. "time"
  9. )
  10. const minBcryptTimingMillis = int64(50) // Ideally should be >100ms, but this should also run on a Raspberry Pi without massive resources
  11. func TestManager_FullScenario_Default_DenyAll(t *testing.T) {
  12. a := newTestManager(t, PermissionDenyAll)
  13. require.Nil(t, a.AddUser("phil", "phil", RoleAdmin, "unit-test"))
  14. require.Nil(t, a.AddUser("ben", "ben", RoleUser, "unit-test"))
  15. require.Nil(t, a.AllowAccess("", "ben", "mytopic", true, true))
  16. require.Nil(t, a.AllowAccess("", "ben", "readme", true, false))
  17. require.Nil(t, a.AllowAccess("", "ben", "writeme", false, true))
  18. require.Nil(t, a.AllowAccess("", "ben", "everyonewrite", false, false)) // How unfair!
  19. require.Nil(t, a.AllowAccess("", Everyone, "announcements", true, false))
  20. require.Nil(t, a.AllowAccess("", Everyone, "everyonewrite", true, true))
  21. require.Nil(t, a.AllowAccess("", Everyone, "up*", false, true)) // Everyone can write to /up*
  22. phil, err := a.Authenticate("phil", "phil")
  23. require.Nil(t, err)
  24. require.Equal(t, "phil", phil.Name)
  25. require.True(t, strings.HasPrefix(phil.Hash, "$2a$10$"))
  26. require.Equal(t, RoleAdmin, phil.Role)
  27. philGrants, err := a.Grants("phil")
  28. require.Nil(t, err)
  29. require.Equal(t, []Grant{}, philGrants)
  30. ben, err := a.Authenticate("ben", "ben")
  31. require.Nil(t, err)
  32. require.Equal(t, "ben", ben.Name)
  33. require.True(t, strings.HasPrefix(ben.Hash, "$2a$10$"))
  34. require.Equal(t, RoleUser, ben.Role)
  35. benGrants, err := a.Grants("ben")
  36. require.Nil(t, err)
  37. require.Equal(t, []Grant{
  38. {"mytopic", PermissionReadWrite},
  39. {"writeme", PermissionWrite},
  40. {"readme", PermissionRead},
  41. {"everyonewrite", PermissionDenyAll},
  42. }, benGrants)
  43. notben, err := a.Authenticate("ben", "this is wrong")
  44. require.Nil(t, notben)
  45. require.Equal(t, ErrUnauthenticated, err)
  46. // Admin can do everything
  47. require.Nil(t, a.Authorize(phil, "sometopic", PermissionWrite))
  48. require.Nil(t, a.Authorize(phil, "mytopic", PermissionRead))
  49. require.Nil(t, a.Authorize(phil, "readme", PermissionWrite))
  50. require.Nil(t, a.Authorize(phil, "writeme", PermissionWrite))
  51. require.Nil(t, a.Authorize(phil, "announcements", PermissionWrite))
  52. require.Nil(t, a.Authorize(phil, "everyonewrite", PermissionWrite))
  53. // User cannot do everything
  54. require.Nil(t, a.Authorize(ben, "mytopic", PermissionWrite))
  55. require.Nil(t, a.Authorize(ben, "mytopic", PermissionRead))
  56. require.Nil(t, a.Authorize(ben, "readme", PermissionRead))
  57. require.Equal(t, ErrUnauthorized, a.Authorize(ben, "readme", PermissionWrite))
  58. require.Equal(t, ErrUnauthorized, a.Authorize(ben, "writeme", PermissionRead))
  59. require.Nil(t, a.Authorize(ben, "writeme", PermissionWrite))
  60. require.Nil(t, a.Authorize(ben, "writeme", PermissionWrite))
  61. require.Equal(t, ErrUnauthorized, a.Authorize(ben, "everyonewrite", PermissionRead))
  62. require.Equal(t, ErrUnauthorized, a.Authorize(ben, "everyonewrite", PermissionWrite))
  63. require.Nil(t, a.Authorize(ben, "announcements", PermissionRead))
  64. require.Equal(t, ErrUnauthorized, a.Authorize(ben, "announcements", PermissionWrite))
  65. // Everyone else can do barely anything
  66. require.Equal(t, ErrUnauthorized, a.Authorize(nil, "sometopicnotinthelist", PermissionRead))
  67. require.Equal(t, ErrUnauthorized, a.Authorize(nil, "sometopicnotinthelist", PermissionWrite))
  68. require.Equal(t, ErrUnauthorized, a.Authorize(nil, "mytopic", PermissionRead))
  69. require.Equal(t, ErrUnauthorized, a.Authorize(nil, "mytopic", PermissionWrite))
  70. require.Equal(t, ErrUnauthorized, a.Authorize(nil, "readme", PermissionRead))
  71. require.Equal(t, ErrUnauthorized, a.Authorize(nil, "readme", PermissionWrite))
  72. require.Equal(t, ErrUnauthorized, a.Authorize(nil, "writeme", PermissionRead))
  73. require.Equal(t, ErrUnauthorized, a.Authorize(nil, "writeme", PermissionWrite))
  74. require.Equal(t, ErrUnauthorized, a.Authorize(nil, "announcements", PermissionWrite))
  75. require.Nil(t, a.Authorize(nil, "announcements", PermissionRead))
  76. require.Nil(t, a.Authorize(nil, "everyonewrite", PermissionRead))
  77. require.Nil(t, a.Authorize(nil, "everyonewrite", PermissionWrite))
  78. require.Nil(t, a.Authorize(nil, "up1234", PermissionWrite)) // Wildcard permission
  79. require.Nil(t, a.Authorize(nil, "up5678", PermissionWrite))
  80. }
  81. func TestManager_AddUser_Invalid(t *testing.T) {
  82. a := newTestManager(t, PermissionDenyAll)
  83. require.Equal(t, ErrInvalidArgument, a.AddUser(" invalid ", "pass", RoleAdmin, "unit-test"))
  84. require.Equal(t, ErrInvalidArgument, a.AddUser("validuser", "pass", "invalid-role", "unit-test"))
  85. }
  86. func TestManager_AddUser_Timing(t *testing.T) {
  87. a := newTestManager(t, PermissionDenyAll)
  88. start := time.Now().UnixMilli()
  89. require.Nil(t, a.AddUser("user", "pass", RoleAdmin, "unit-test"))
  90. require.GreaterOrEqual(t, time.Now().UnixMilli()-start, minBcryptTimingMillis)
  91. }
  92. func TestManager_Authenticate_Timing(t *testing.T) {
  93. a := newTestManager(t, PermissionDenyAll)
  94. require.Nil(t, a.AddUser("user", "pass", RoleAdmin, "unit-test"))
  95. // Timing a correct attempt
  96. start := time.Now().UnixMilli()
  97. _, err := a.Authenticate("user", "pass")
  98. require.Nil(t, err)
  99. require.GreaterOrEqual(t, time.Now().UnixMilli()-start, minBcryptTimingMillis)
  100. // Timing an incorrect attempt
  101. start = time.Now().UnixMilli()
  102. _, err = a.Authenticate("user", "INCORRECT")
  103. require.Equal(t, ErrUnauthenticated, err)
  104. require.GreaterOrEqual(t, time.Now().UnixMilli()-start, minBcryptTimingMillis)
  105. // Timing a non-existing user attempt
  106. start = time.Now().UnixMilli()
  107. _, err = a.Authenticate("DOES-NOT-EXIST", "hithere")
  108. require.Equal(t, ErrUnauthenticated, err)
  109. require.GreaterOrEqual(t, time.Now().UnixMilli()-start, minBcryptTimingMillis)
  110. }
  111. func TestManager_UserManagement(t *testing.T) {
  112. a := newTestManager(t, PermissionDenyAll)
  113. require.Nil(t, a.AddUser("phil", "phil", RoleAdmin, "unit-test"))
  114. require.Nil(t, a.AddUser("ben", "ben", RoleUser, "unit-test"))
  115. require.Nil(t, a.AllowAccess("", "ben", "mytopic", true, true))
  116. require.Nil(t, a.AllowAccess("", "ben", "readme", true, false))
  117. require.Nil(t, a.AllowAccess("", "ben", "writeme", false, true))
  118. require.Nil(t, a.AllowAccess("", "ben", "everyonewrite", false, false)) // How unfair!
  119. require.Nil(t, a.AllowAccess("", Everyone, "announcements", true, false))
  120. require.Nil(t, a.AllowAccess("", Everyone, "everyonewrite", true, true))
  121. // Query user details
  122. phil, err := a.User("phil")
  123. require.Nil(t, err)
  124. require.Equal(t, "phil", phil.Name)
  125. require.True(t, strings.HasPrefix(phil.Hash, "$2a$10$"))
  126. require.Equal(t, RoleAdmin, phil.Role)
  127. philGrants, err := a.Grants("phil")
  128. require.Nil(t, err)
  129. require.Equal(t, []Grant{}, philGrants)
  130. ben, err := a.User("ben")
  131. require.Nil(t, err)
  132. require.Equal(t, "ben", ben.Name)
  133. require.True(t, strings.HasPrefix(ben.Hash, "$2a$10$"))
  134. require.Equal(t, RoleUser, ben.Role)
  135. benGrants, err := a.Grants("ben")
  136. require.Nil(t, err)
  137. require.Equal(t, []Grant{
  138. {"mytopic", PermissionReadWrite},
  139. {"writeme", PermissionWrite},
  140. {"readme", PermissionRead},
  141. {"everyonewrite", PermissionDenyAll},
  142. }, benGrants)
  143. everyone, err := a.User(Everyone)
  144. require.Nil(t, err)
  145. require.Equal(t, "*", everyone.Name)
  146. require.Equal(t, "", everyone.Hash)
  147. require.Equal(t, RoleAnonymous, everyone.Role)
  148. everyoneGrants, err := a.Grants(Everyone)
  149. require.Nil(t, err)
  150. require.Equal(t, []Grant{
  151. {"everyonewrite", PermissionReadWrite},
  152. {"announcements", PermissionRead},
  153. }, everyoneGrants)
  154. // Ben: Before revoking
  155. require.Nil(t, a.AllowAccess("", "ben", "mytopic", true, true)) // Overwrite!
  156. require.Nil(t, a.AllowAccess("", "ben", "readme", true, false))
  157. require.Nil(t, a.AllowAccess("", "ben", "writeme", false, true))
  158. require.Nil(t, a.Authorize(ben, "mytopic", PermissionRead))
  159. require.Nil(t, a.Authorize(ben, "mytopic", PermissionWrite))
  160. require.Nil(t, a.Authorize(ben, "readme", PermissionRead))
  161. require.Nil(t, a.Authorize(ben, "writeme", PermissionWrite))
  162. // Revoke access for "ben" to "mytopic", then check again
  163. require.Nil(t, a.ResetAccess("ben", "mytopic"))
  164. require.Equal(t, ErrUnauthorized, a.Authorize(ben, "mytopic", PermissionWrite)) // Revoked
  165. require.Equal(t, ErrUnauthorized, a.Authorize(ben, "mytopic", PermissionRead)) // Revoked
  166. require.Nil(t, a.Authorize(ben, "readme", PermissionRead)) // Unchanged
  167. require.Nil(t, a.Authorize(ben, "writeme", PermissionWrite)) // Unchanged
  168. // Revoke rest of the access
  169. require.Nil(t, a.ResetAccess("ben", ""))
  170. require.Equal(t, ErrUnauthorized, a.Authorize(ben, "readme", PermissionRead)) // Revoked
  171. require.Equal(t, ErrUnauthorized, a.Authorize(ben, "wrtiteme", PermissionWrite)) // Revoked
  172. // User list
  173. users, err := a.Users()
  174. require.Nil(t, err)
  175. require.Equal(t, 3, len(users))
  176. require.Equal(t, "phil", users[0].Name)
  177. require.Equal(t, "ben", users[1].Name)
  178. require.Equal(t, "*", users[2].Name)
  179. // Remove user
  180. require.Nil(t, a.RemoveUser("ben"))
  181. _, err = a.User("ben")
  182. require.Equal(t, ErrUserNotFound, err)
  183. users, err = a.Users()
  184. require.Nil(t, err)
  185. require.Equal(t, 2, len(users))
  186. require.Equal(t, "phil", users[0].Name)
  187. require.Equal(t, "*", users[1].Name)
  188. }
  189. func TestManager_ChangePassword(t *testing.T) {
  190. a := newTestManager(t, PermissionDenyAll)
  191. require.Nil(t, a.AddUser("phil", "phil", RoleAdmin, "unit-test"))
  192. _, err := a.Authenticate("phil", "phil")
  193. require.Nil(t, err)
  194. require.Nil(t, a.ChangePassword("phil", "newpass"))
  195. _, err = a.Authenticate("phil", "phil")
  196. require.Equal(t, ErrUnauthenticated, err)
  197. _, err = a.Authenticate("phil", "newpass")
  198. require.Nil(t, err)
  199. }
  200. func TestManager_ChangeRole(t *testing.T) {
  201. a := newTestManager(t, PermissionDenyAll)
  202. require.Nil(t, a.AddUser("ben", "ben", RoleUser, "unit-test"))
  203. require.Nil(t, a.AllowAccess("", "ben", "mytopic", true, true))
  204. require.Nil(t, a.AllowAccess("", "ben", "readme", true, false))
  205. ben, err := a.User("ben")
  206. require.Nil(t, err)
  207. require.Equal(t, RoleUser, ben.Role)
  208. benGrants, err := a.Grants("ben")
  209. require.Nil(t, err)
  210. require.Equal(t, 2, len(benGrants))
  211. require.Nil(t, a.ChangeRole("ben", RoleAdmin))
  212. ben, err = a.User("ben")
  213. require.Nil(t, err)
  214. require.Equal(t, RoleAdmin, ben.Role)
  215. benGrants, err = a.Grants("ben")
  216. require.Nil(t, err)
  217. require.Equal(t, 0, len(benGrants))
  218. }
  219. func TestManager_ChangeRoleFromTierUserToAdmin(t *testing.T) {
  220. a := newTestManager(t, PermissionDenyAll)
  221. require.Nil(t, a.CreateTier(&Tier{
  222. Code: "pro",
  223. Name: "ntfy Pro",
  224. Paid: true,
  225. MessagesLimit: 5_000,
  226. MessagesExpiryDuration: 3 * 24 * time.Hour,
  227. EmailsLimit: 50,
  228. ReservationsLimit: 5,
  229. AttachmentFileSizeLimit: 52428800,
  230. AttachmentTotalSizeLimit: 524288000,
  231. AttachmentExpiryDuration: 24 * time.Hour,
  232. }))
  233. require.Nil(t, a.AddUser("ben", "ben", RoleUser, "unit-test"))
  234. require.Nil(t, a.ChangeTier("ben", "pro"))
  235. require.Nil(t, a.AllowAccess("ben", "ben", "mytopic", true, true))
  236. require.Nil(t, a.AllowAccess("ben", Everyone, "mytopic", false, false))
  237. ben, err := a.User("ben")
  238. require.Nil(t, err)
  239. require.Equal(t, RoleUser, ben.Role)
  240. require.Equal(t, "pro", ben.Tier.Code)
  241. require.Equal(t, true, ben.Tier.Paid)
  242. require.Equal(t, int64(5000), ben.Tier.MessagesLimit)
  243. require.Equal(t, 3*24*time.Hour, ben.Tier.MessagesExpiryDuration)
  244. require.Equal(t, int64(50), ben.Tier.EmailsLimit)
  245. require.Equal(t, int64(5), ben.Tier.ReservationsLimit)
  246. require.Equal(t, int64(52428800), ben.Tier.AttachmentFileSizeLimit)
  247. require.Equal(t, int64(524288000), ben.Tier.AttachmentTotalSizeLimit)
  248. require.Equal(t, 24*time.Hour, ben.Tier.AttachmentExpiryDuration)
  249. benGrants, err := a.Grants("ben")
  250. require.Nil(t, err)
  251. require.Equal(t, 1, len(benGrants))
  252. require.Equal(t, PermissionReadWrite, benGrants[0].Allow)
  253. everyoneGrants, err := a.Grants(Everyone)
  254. require.Nil(t, err)
  255. require.Equal(t, 1, len(everyoneGrants))
  256. require.Equal(t, PermissionDenyAll, everyoneGrants[0].Allow)
  257. // Switch to admin, this should remove all grants and owned ACL entries
  258. require.Nil(t, a.ChangeRole("ben", RoleAdmin))
  259. benGrants, err = a.Grants("ben")
  260. require.Nil(t, err)
  261. require.Equal(t, 0, len(benGrants))
  262. everyoneGrants, err = a.Grants(Everyone)
  263. require.Nil(t, err)
  264. require.Equal(t, 0, len(everyoneGrants))
  265. }
  266. func TestManager_Token_Valid(t *testing.T) {
  267. a := newTestManager(t, PermissionDenyAll)
  268. require.Nil(t, a.AddUser("ben", "ben", RoleUser, "unit-test"))
  269. u, err := a.User("ben")
  270. require.Nil(t, err)
  271. // Create token for user
  272. token, err := a.CreateToken(u)
  273. require.Nil(t, err)
  274. require.NotEmpty(t, token.Value)
  275. require.True(t, time.Now().Add(71*time.Hour).Unix() < token.Expires.Unix())
  276. u2, err := a.AuthenticateToken(token.Value)
  277. require.Nil(t, err)
  278. require.Equal(t, u.Name, u2.Name)
  279. require.Equal(t, token.Value, u2.Token)
  280. // Remove token and auth again
  281. require.Nil(t, a.RemoveToken(u2))
  282. u3, err := a.AuthenticateToken(token.Value)
  283. require.Equal(t, ErrUnauthenticated, err)
  284. require.Nil(t, u3)
  285. }
  286. func TestManager_Token_Invalid(t *testing.T) {
  287. a := newTestManager(t, PermissionDenyAll)
  288. require.Nil(t, a.AddUser("ben", "ben", RoleUser, "unit-test"))
  289. u, err := a.AuthenticateToken(strings.Repeat("x", 32)) // 32 == token length
  290. require.Nil(t, u)
  291. require.Equal(t, ErrUnauthenticated, err)
  292. u, err = a.AuthenticateToken("not long enough anyway")
  293. require.Nil(t, u)
  294. require.Equal(t, ErrUnauthenticated, err)
  295. }
  296. func TestManager_Token_Expire(t *testing.T) {
  297. a := newTestManager(t, PermissionDenyAll)
  298. require.Nil(t, a.AddUser("ben", "ben", RoleUser, "unit-test"))
  299. u, err := a.User("ben")
  300. require.Nil(t, err)
  301. // Create tokens for user
  302. token1, err := a.CreateToken(u)
  303. require.Nil(t, err)
  304. require.NotEmpty(t, token1.Value)
  305. require.True(t, time.Now().Add(71*time.Hour).Unix() < token1.Expires.Unix())
  306. token2, err := a.CreateToken(u)
  307. require.Nil(t, err)
  308. require.NotEmpty(t, token2.Value)
  309. require.NotEqual(t, token1.Value, token2.Value)
  310. require.True(t, time.Now().Add(71*time.Hour).Unix() < token2.Expires.Unix())
  311. // See that tokens work
  312. _, err = a.AuthenticateToken(token1.Value)
  313. require.Nil(t, err)
  314. _, err = a.AuthenticateToken(token2.Value)
  315. require.Nil(t, err)
  316. // Modify token expiration in database
  317. _, err = a.db.Exec("UPDATE user_token SET expires = 1 WHERE token = ?", token1.Value)
  318. require.Nil(t, err)
  319. // Now token1 shouldn't work anymore
  320. _, err = a.AuthenticateToken(token1.Value)
  321. require.Equal(t, ErrUnauthenticated, err)
  322. result, err := a.db.Query("SELECT * from user_token WHERE token = ?", token1.Value)
  323. require.Nil(t, err)
  324. require.True(t, result.Next()) // Still a matching row
  325. require.Nil(t, result.Close())
  326. // Expire tokens and check database rows
  327. require.Nil(t, a.RemoveExpiredTokens())
  328. result, err = a.db.Query("SELECT * from user_token WHERE token = ?", token1.Value)
  329. require.Nil(t, err)
  330. require.False(t, result.Next()) // No matching row!
  331. require.Nil(t, result.Close())
  332. }
  333. func TestManager_Token_Extend(t *testing.T) {
  334. a := newTestManager(t, PermissionDenyAll)
  335. require.Nil(t, a.AddUser("ben", "ben", RoleUser, "unit-test"))
  336. // Try to extend token for user without token
  337. u, err := a.User("ben")
  338. require.Nil(t, err)
  339. _, err = a.ExtendToken(u)
  340. require.Equal(t, errNoTokenProvided, err)
  341. // Create token for user
  342. token, err := a.CreateToken(u)
  343. require.Nil(t, err)
  344. require.NotEmpty(t, token.Value)
  345. userWithToken, err := a.AuthenticateToken(token.Value)
  346. require.Nil(t, err)
  347. time.Sleep(1100 * time.Millisecond)
  348. extendedToken, err := a.ExtendToken(userWithToken)
  349. require.Nil(t, err)
  350. require.Equal(t, token.Value, extendedToken.Value)
  351. require.True(t, token.Expires.Unix() < extendedToken.Expires.Unix())
  352. }
  353. func TestManager_Token_MaxCount_AutoDelete(t *testing.T) {
  354. a := newTestManager(t, PermissionDenyAll)
  355. require.Nil(t, a.AddUser("ben", "ben", RoleUser, "unit-test"))
  356. // Try to extend token for user without token
  357. u, err := a.User("ben")
  358. require.Nil(t, err)
  359. // Tokens
  360. baseTime := time.Now().Add(24 * time.Hour)
  361. tokens := make([]string, 0)
  362. for i := 0; i < 12; i++ {
  363. token, err := a.CreateToken(u)
  364. require.Nil(t, err)
  365. require.NotEmpty(t, token.Value)
  366. tokens = append(tokens, token.Value)
  367. // Manually modify expiry date to avoid sorting issues (this is a hack)
  368. _, err = a.db.Exec(`UPDATE user_token SET expires=? WHERE token=?`, baseTime.Add(time.Duration(i)*time.Minute).Unix(), token.Value)
  369. require.Nil(t, err)
  370. }
  371. _, err = a.AuthenticateToken(tokens[0])
  372. require.Equal(t, ErrUnauthenticated, err)
  373. _, err = a.AuthenticateToken(tokens[1])
  374. require.Equal(t, ErrUnauthenticated, err)
  375. for i := 2; i < 12; i++ {
  376. userWithToken, err := a.AuthenticateToken(tokens[i])
  377. require.Nil(t, err, "token[%d]=%s failed", i, tokens[i])
  378. require.Equal(t, "ben", userWithToken.Name)
  379. require.Equal(t, tokens[i], userWithToken.Token)
  380. }
  381. var count int
  382. rows, err := a.db.Query(`SELECT COUNT(*) FROM user_token`)
  383. require.Nil(t, err)
  384. require.True(t, rows.Next())
  385. require.Nil(t, rows.Scan(&count))
  386. require.Equal(t, 10, count)
  387. }
  388. func TestManager_EnqueueStats(t *testing.T) {
  389. a, err := newManager(filepath.Join(t.TempDir(), "db"), "", PermissionReadWrite, 1500*time.Millisecond)
  390. require.Nil(t, err)
  391. require.Nil(t, a.AddUser("ben", "ben", RoleUser, "unit-test"))
  392. // Baseline: No messages or emails
  393. u, err := a.User("ben")
  394. require.Nil(t, err)
  395. require.Equal(t, int64(0), u.Stats.Messages)
  396. require.Equal(t, int64(0), u.Stats.Emails)
  397. u.Stats.Messages = 11
  398. u.Stats.Emails = 2
  399. a.EnqueueStats(u)
  400. // Still no change, because it's queued asynchronously
  401. u, err = a.User("ben")
  402. require.Nil(t, err)
  403. require.Equal(t, int64(0), u.Stats.Messages)
  404. require.Equal(t, int64(0), u.Stats.Emails)
  405. // After 2 seconds they should be persisted
  406. time.Sleep(2 * time.Second)
  407. u, err = a.User("ben")
  408. require.Nil(t, err)
  409. require.Equal(t, int64(11), u.Stats.Messages)
  410. require.Equal(t, int64(2), u.Stats.Emails)
  411. }
  412. func TestManager_ChangeSettings(t *testing.T) {
  413. a, err := newManager(filepath.Join(t.TempDir(), "db"), "", PermissionReadWrite, 1500*time.Millisecond)
  414. require.Nil(t, err)
  415. require.Nil(t, a.AddUser("ben", "ben", RoleUser, "unit-test"))
  416. // No settings
  417. u, err := a.User("ben")
  418. require.Nil(t, err)
  419. require.Nil(t, u.Prefs.Subscriptions)
  420. require.Nil(t, u.Prefs.Notification)
  421. require.Equal(t, "", u.Prefs.Language)
  422. // Save with new settings
  423. u.Prefs = &Prefs{
  424. Language: "de",
  425. Notification: &NotificationPrefs{
  426. Sound: "ding",
  427. MinPriority: 2,
  428. },
  429. Subscriptions: []*Subscription{
  430. {
  431. ID: "someID",
  432. BaseURL: "https://ntfy.sh",
  433. Topic: "mytopic",
  434. DisplayName: "My Topic",
  435. },
  436. },
  437. }
  438. require.Nil(t, a.ChangeSettings(u))
  439. // Read again
  440. u, err = a.User("ben")
  441. require.Nil(t, err)
  442. require.Equal(t, "de", u.Prefs.Language)
  443. require.Equal(t, "ding", u.Prefs.Notification.Sound)
  444. require.Equal(t, 2, u.Prefs.Notification.MinPriority)
  445. require.Equal(t, 0, u.Prefs.Notification.DeleteAfter)
  446. require.Equal(t, "someID", u.Prefs.Subscriptions[0].ID)
  447. require.Equal(t, "https://ntfy.sh", u.Prefs.Subscriptions[0].BaseURL)
  448. require.Equal(t, "mytopic", u.Prefs.Subscriptions[0].Topic)
  449. require.Equal(t, "My Topic", u.Prefs.Subscriptions[0].DisplayName)
  450. }
  451. func TestSqliteCache_Migration_From1(t *testing.T) {
  452. filename := filepath.Join(t.TempDir(), "user.db")
  453. db, err := sql.Open("sqlite3", filename)
  454. require.Nil(t, err)
  455. // Create "version 1" schema
  456. _, err = db.Exec(`
  457. BEGIN;
  458. CREATE TABLE IF NOT EXISTS user (
  459. user TEXT NOT NULL PRIMARY KEY,
  460. pass TEXT NOT NULL,
  461. role TEXT NOT NULL
  462. );
  463. CREATE TABLE IF NOT EXISTS access (
  464. user TEXT NOT NULL,
  465. topic TEXT NOT NULL,
  466. read INT NOT NULL,
  467. write INT NOT NULL,
  468. PRIMARY KEY (topic, user)
  469. );
  470. CREATE TABLE IF NOT EXISTS schemaVersion (
  471. id INT PRIMARY KEY,
  472. version INT NOT NULL
  473. );
  474. INSERT INTO schemaVersion (id, version) VALUES (1, 1);
  475. COMMIT;
  476. `)
  477. require.Nil(t, err)
  478. // Insert a bunch of users and ACL entries
  479. _, err = db.Exec(`
  480. BEGIN;
  481. INSERT INTO user (user, pass, role) VALUES ('ben', '$2a$10$EEp6gBheOsqEFsXlo523E.gBVoeg1ytphXiEvTPlNzkenBlHZBPQy', 'user');
  482. INSERT INTO user (user, pass, role) VALUES ('phil', '$2a$10$YLiO8U21sX1uhZamTLJXHuxgVC0Z/GKISibrKCLohPgtG7yIxSk4C', 'admin');
  483. INSERT INTO access (user, topic, read, write) VALUES ('ben', 'stats', 1, 1);
  484. INSERT INTO access (user, topic, read, write) VALUES ('ben', 'secret', 1, 0);
  485. INSERT INTO access (user, topic, read, write) VALUES ('*', 'stats', 1, 0);
  486. COMMIT;
  487. `)
  488. require.Nil(t, err)
  489. // Create manager to trigger migration
  490. a := newTestManagerFromFile(t, filename, "", PermissionDenyAll, userStatsQueueWriterInterval)
  491. checkSchemaVersion(t, a.db)
  492. users, err := a.Users()
  493. require.Nil(t, err)
  494. require.Equal(t, 3, len(users))
  495. phil, ben, everyone := users[0], users[1], users[2]
  496. philGrants, err := a.Grants("phil")
  497. require.Nil(t, err)
  498. benGrants, err := a.Grants("ben")
  499. require.Nil(t, err)
  500. everyoneGrants, err := a.Grants(Everyone)
  501. require.Nil(t, err)
  502. require.Equal(t, "phil", phil.Name)
  503. require.Equal(t, RoleAdmin, phil.Role)
  504. require.Equal(t, syncTopicLength, len(phil.SyncTopic))
  505. require.Equal(t, 0, len(philGrants))
  506. require.Equal(t, "ben", ben.Name)
  507. require.Equal(t, RoleUser, ben.Role)
  508. require.Equal(t, syncTopicLength, len(ben.SyncTopic))
  509. require.NotEqual(t, ben.SyncTopic, phil.SyncTopic)
  510. require.Equal(t, 2, len(benGrants))
  511. require.Equal(t, "stats", benGrants[0].TopicPattern)
  512. require.Equal(t, PermissionReadWrite, benGrants[0].Allow)
  513. require.Equal(t, "secret", benGrants[1].TopicPattern)
  514. require.Equal(t, PermissionRead, benGrants[1].Allow)
  515. require.Equal(t, Everyone, everyone.Name)
  516. require.Equal(t, RoleAnonymous, everyone.Role)
  517. require.Equal(t, 1, len(everyoneGrants))
  518. require.Equal(t, "stats", everyoneGrants[0].TopicPattern)
  519. require.Equal(t, PermissionRead, everyoneGrants[0].Allow)
  520. }
  521. func checkSchemaVersion(t *testing.T, db *sql.DB) {
  522. rows, err := db.Query(`SELECT version FROM schemaVersion`)
  523. require.Nil(t, err)
  524. require.True(t, rows.Next())
  525. var schemaVersion int
  526. require.Nil(t, rows.Scan(&schemaVersion))
  527. require.Equal(t, currentSchemaVersion, schemaVersion)
  528. require.Nil(t, rows.Close())
  529. }
  530. func newTestManager(t *testing.T, defaultAccess Permission) *Manager {
  531. return newTestManagerFromFile(t, filepath.Join(t.TempDir(), "user.db"), "", defaultAccess, userStatsQueueWriterInterval)
  532. }
  533. func newTestManagerFromFile(t *testing.T, filename, startupQueries string, defaultAccess Permission, statsWriterInterval time.Duration) *Manager {
  534. a, err := newManager(filename, startupQueries, defaultAccess, statsWriterInterval)
  535. require.Nil(t, err)
  536. return a
  537. }