1
0

manager_test.go 26 KB

123456789101112131415161718192021222324252627282930313233343536373839404142434445464748495051525354555657585960616263646566676869707172737475767778798081828384858687888990919293949596979899100101102103104105106107108109110111112113114115116117118119120121122123124125126127128129130131132133134135136137138139140141142143144145146147148149150151152153154155156157158159160161162163164165166167168169170171172173174175176177178179180181182183184185186187188189190191192193194195196197198199200201202203204205206207208209210211212213214215216217218219220221222223224225226227228229230231232233234235236237238239240241242243244245246247248249250251252253254255256257258259260261262263264265266267268269270271272273274275276277278279280281282283284285286287288289290291292293294295296297298299300301302303304305306307308309310311312313314315316317318319320321322323324325326327328329330331332333334335336337338339340341342343344345346347348349350351352353354355356357358359360361362363364365366367368369370371372373374375376377378379380381382383384385386387388389390391392393394395396397398399400401402403404405406407408409410411412413414415416417418419420421422423424425426427428429430431432433434435436437438439440441442443444445446447448449450451452453454455456457458459460461462463464465466467468469470471472473474475476477478479480481482483484485486487488489490491492493494495496497498499500501502503504505506507508509510511512513514515516517518519520521522523524525526527528529530531532533534535536537538539540541542543544545546547548549550551552553554555556557558559560561562563564565566567568569570571572573574575576577578579580581582583584585586587588589590591592593594595596597598599600601602603604605606607608609610611612613614615616617618619620621622623624625626627628629630631632633634635636637638639640641642643644645646647648649650651652653654655656657658659660661662663664665666667668669670671672673674675676677678679680681682683684685686687688689690691692693694695696697698699700701702703704705706707708709710711712713714715716717718719720721722723724725726727728729730731
  1. package user
  2. import (
  3. "database/sql"
  4. "github.com/stretchr/testify/require"
  5. "golang.org/x/crypto/bcrypt"
  6. "heckel.io/ntfy/util"
  7. "path/filepath"
  8. "strings"
  9. "testing"
  10. "time"
  11. )
  12. const minBcryptTimingMillis = int64(50) // Ideally should be >100ms, but this should also run on a Raspberry Pi without massive resources
  13. func TestManager_FullScenario_Default_DenyAll(t *testing.T) {
  14. a := newTestManagerFromFile(t, filepath.Join(t.TempDir(), "user.db"), "", PermissionDenyAll, DefaultUserPasswordBcryptCost, DefaultUserStatsQueueWriterInterval)
  15. require.Nil(t, a.AddUser("phil", "phil", RoleAdmin))
  16. require.Nil(t, a.AddUser("ben", "ben", RoleUser))
  17. require.Nil(t, a.AllowAccess("ben", "mytopic", PermissionReadWrite))
  18. require.Nil(t, a.AllowAccess("ben", "readme", PermissionRead))
  19. require.Nil(t, a.AllowAccess("ben", "writeme", PermissionWrite))
  20. require.Nil(t, a.AllowAccess("ben", "everyonewrite", PermissionDenyAll)) // How unfair!
  21. require.Nil(t, a.AllowAccess(Everyone, "announcements", PermissionRead))
  22. require.Nil(t, a.AllowAccess(Everyone, "everyonewrite", PermissionReadWrite))
  23. require.Nil(t, a.AllowAccess(Everyone, "up*", PermissionWrite)) // Everyone can write to /up*
  24. phil, err := a.Authenticate("phil", "phil")
  25. require.Nil(t, err)
  26. require.Equal(t, "phil", phil.Name)
  27. require.True(t, strings.HasPrefix(phil.Hash, "$2a$10$"))
  28. require.Equal(t, RoleAdmin, phil.Role)
  29. philGrants, err := a.Grants("phil")
  30. require.Nil(t, err)
  31. require.Equal(t, []Grant{}, philGrants)
  32. ben, err := a.Authenticate("ben", "ben")
  33. require.Nil(t, err)
  34. require.Equal(t, "ben", ben.Name)
  35. require.True(t, strings.HasPrefix(ben.Hash, "$2a$10$"))
  36. require.Equal(t, RoleUser, ben.Role)
  37. benGrants, err := a.Grants("ben")
  38. require.Nil(t, err)
  39. require.Equal(t, []Grant{
  40. {"mytopic", PermissionReadWrite},
  41. {"writeme", PermissionWrite},
  42. {"readme", PermissionRead},
  43. {"everyonewrite", PermissionDenyAll},
  44. }, benGrants)
  45. notben, err := a.Authenticate("ben", "this is wrong")
  46. require.Nil(t, notben)
  47. require.Equal(t, ErrUnauthenticated, err)
  48. // Admin can do everything
  49. require.Nil(t, a.Authorize(phil, "sometopic", PermissionWrite))
  50. require.Nil(t, a.Authorize(phil, "mytopic", PermissionRead))
  51. require.Nil(t, a.Authorize(phil, "readme", PermissionWrite))
  52. require.Nil(t, a.Authorize(phil, "writeme", PermissionWrite))
  53. require.Nil(t, a.Authorize(phil, "announcements", PermissionWrite))
  54. require.Nil(t, a.Authorize(phil, "everyonewrite", PermissionWrite))
  55. // User cannot do everything
  56. require.Nil(t, a.Authorize(ben, "mytopic", PermissionWrite))
  57. require.Nil(t, a.Authorize(ben, "mytopic", PermissionRead))
  58. require.Nil(t, a.Authorize(ben, "readme", PermissionRead))
  59. require.Equal(t, ErrUnauthorized, a.Authorize(ben, "readme", PermissionWrite))
  60. require.Equal(t, ErrUnauthorized, a.Authorize(ben, "writeme", PermissionRead))
  61. require.Nil(t, a.Authorize(ben, "writeme", PermissionWrite))
  62. require.Nil(t, a.Authorize(ben, "writeme", PermissionWrite))
  63. require.Equal(t, ErrUnauthorized, a.Authorize(ben, "everyonewrite", PermissionRead))
  64. require.Equal(t, ErrUnauthorized, a.Authorize(ben, "everyonewrite", PermissionWrite))
  65. require.Nil(t, a.Authorize(ben, "announcements", PermissionRead))
  66. require.Equal(t, ErrUnauthorized, a.Authorize(ben, "announcements", PermissionWrite))
  67. // Everyone else can do barely anything
  68. require.Equal(t, ErrUnauthorized, a.Authorize(nil, "sometopicnotinthelist", PermissionRead))
  69. require.Equal(t, ErrUnauthorized, a.Authorize(nil, "sometopicnotinthelist", PermissionWrite))
  70. require.Equal(t, ErrUnauthorized, a.Authorize(nil, "mytopic", PermissionRead))
  71. require.Equal(t, ErrUnauthorized, a.Authorize(nil, "mytopic", PermissionWrite))
  72. require.Equal(t, ErrUnauthorized, a.Authorize(nil, "readme", PermissionRead))
  73. require.Equal(t, ErrUnauthorized, a.Authorize(nil, "readme", PermissionWrite))
  74. require.Equal(t, ErrUnauthorized, a.Authorize(nil, "writeme", PermissionRead))
  75. require.Equal(t, ErrUnauthorized, a.Authorize(nil, "writeme", PermissionWrite))
  76. require.Equal(t, ErrUnauthorized, a.Authorize(nil, "announcements", PermissionWrite))
  77. require.Nil(t, a.Authorize(nil, "announcements", PermissionRead))
  78. require.Nil(t, a.Authorize(nil, "everyonewrite", PermissionRead))
  79. require.Nil(t, a.Authorize(nil, "everyonewrite", PermissionWrite))
  80. require.Nil(t, a.Authorize(nil, "up1234", PermissionWrite)) // Wildcard permission
  81. require.Nil(t, a.Authorize(nil, "up5678", PermissionWrite))
  82. }
  83. func TestManager_AddUser_Invalid(t *testing.T) {
  84. a := newTestManager(t, PermissionDenyAll)
  85. require.Equal(t, ErrInvalidArgument, a.AddUser(" invalid ", "pass", RoleAdmin))
  86. require.Equal(t, ErrInvalidArgument, a.AddUser("validuser", "pass", "invalid-role"))
  87. }
  88. func TestManager_AddUser_Timing(t *testing.T) {
  89. a := newTestManagerFromFile(t, filepath.Join(t.TempDir(), "user.db"), "", PermissionDenyAll, DefaultUserPasswordBcryptCost, DefaultUserStatsQueueWriterInterval)
  90. start := time.Now().UnixMilli()
  91. require.Nil(t, a.AddUser("user", "pass", RoleAdmin))
  92. require.GreaterOrEqual(t, time.Now().UnixMilli()-start, minBcryptTimingMillis)
  93. }
  94. func TestManager_Authenticate_Timing(t *testing.T) {
  95. a := newTestManagerFromFile(t, filepath.Join(t.TempDir(), "user.db"), "", PermissionDenyAll, DefaultUserPasswordBcryptCost, DefaultUserStatsQueueWriterInterval)
  96. require.Nil(t, a.AddUser("user", "pass", RoleAdmin))
  97. // Timing a correct attempt
  98. start := time.Now().UnixMilli()
  99. _, err := a.Authenticate("user", "pass")
  100. require.Nil(t, err)
  101. require.GreaterOrEqual(t, time.Now().UnixMilli()-start, minBcryptTimingMillis)
  102. // Timing an incorrect attempt
  103. start = time.Now().UnixMilli()
  104. _, err = a.Authenticate("user", "INCORRECT")
  105. require.Equal(t, ErrUnauthenticated, err)
  106. require.GreaterOrEqual(t, time.Now().UnixMilli()-start, minBcryptTimingMillis)
  107. // Timing a non-existing user attempt
  108. start = time.Now().UnixMilli()
  109. _, err = a.Authenticate("DOES-NOT-EXIST", "hithere")
  110. require.Equal(t, ErrUnauthenticated, err)
  111. require.GreaterOrEqual(t, time.Now().UnixMilli()-start, minBcryptTimingMillis)
  112. }
  113. func TestManager_MarkUserRemoved_RemoveDeletedUsers(t *testing.T) {
  114. a := newTestManager(t, PermissionDenyAll)
  115. // Create user, add reservations and token
  116. require.Nil(t, a.AddUser("user", "pass", RoleAdmin))
  117. require.Nil(t, a.AddReservation("user", "mytopic", PermissionRead))
  118. u, err := a.User("user")
  119. require.Nil(t, err)
  120. require.False(t, u.Deleted)
  121. token, err := a.CreateToken(u.ID, "", time.Now().Add(time.Hour))
  122. require.Nil(t, err)
  123. u, err = a.Authenticate("user", "pass")
  124. require.Nil(t, err)
  125. _, err = a.AuthenticateToken(token.Value)
  126. require.Nil(t, err)
  127. reservations, err := a.Reservations("user")
  128. require.Nil(t, err)
  129. require.Equal(t, 1, len(reservations))
  130. // Mark deleted: cannot auth anymore, and all reservations are gone
  131. require.Nil(t, a.MarkUserRemoved(u))
  132. _, err = a.Authenticate("user", "pass")
  133. require.Equal(t, ErrUnauthenticated, err)
  134. _, err = a.AuthenticateToken(token.Value)
  135. require.Equal(t, ErrUnauthenticated, err)
  136. reservations, err = a.Reservations("user")
  137. require.Nil(t, err)
  138. require.Equal(t, 0, len(reservations))
  139. // Make sure user is still there
  140. u, err = a.User("user")
  141. require.Nil(t, err)
  142. require.True(t, u.Deleted)
  143. _, err = a.db.Exec("UPDATE user SET deleted = ? WHERE id = ?", time.Now().Add(-1*(userHardDeleteAfterDuration+time.Hour)).Unix(), u.ID)
  144. require.Nil(t, err)
  145. require.Nil(t, a.RemoveDeletedUsers())
  146. _, err = a.User("user")
  147. require.Equal(t, ErrUserNotFound, err)
  148. }
  149. func TestManager_UserManagement(t *testing.T) {
  150. a := newTestManager(t, PermissionDenyAll)
  151. require.Nil(t, a.AddUser("phil", "phil", RoleAdmin))
  152. require.Nil(t, a.AddUser("ben", "ben", RoleUser))
  153. require.Nil(t, a.AllowAccess("ben", "mytopic", PermissionReadWrite))
  154. require.Nil(t, a.AllowAccess("ben", "readme", PermissionRead))
  155. require.Nil(t, a.AllowAccess("ben", "writeme", PermissionWrite))
  156. require.Nil(t, a.AllowAccess("ben", "everyonewrite", PermissionDenyAll)) // How unfair!
  157. require.Nil(t, a.AllowAccess(Everyone, "announcements", PermissionRead))
  158. require.Nil(t, a.AllowAccess(Everyone, "everyonewrite", PermissionReadWrite))
  159. // Query user details
  160. phil, err := a.User("phil")
  161. require.Nil(t, err)
  162. require.Equal(t, "phil", phil.Name)
  163. require.True(t, strings.HasPrefix(phil.Hash, "$2a$04$")) // Min cost for testing
  164. require.Equal(t, RoleAdmin, phil.Role)
  165. philGrants, err := a.Grants("phil")
  166. require.Nil(t, err)
  167. require.Equal(t, []Grant{}, philGrants)
  168. ben, err := a.User("ben")
  169. require.Nil(t, err)
  170. require.Equal(t, "ben", ben.Name)
  171. require.True(t, strings.HasPrefix(ben.Hash, "$2a$04$")) // Min cost for testing
  172. require.Equal(t, RoleUser, ben.Role)
  173. benGrants, err := a.Grants("ben")
  174. require.Nil(t, err)
  175. require.Equal(t, []Grant{
  176. {"mytopic", PermissionReadWrite},
  177. {"writeme", PermissionWrite},
  178. {"readme", PermissionRead},
  179. {"everyonewrite", PermissionDenyAll},
  180. }, benGrants)
  181. everyone, err := a.User(Everyone)
  182. require.Nil(t, err)
  183. require.Equal(t, "*", everyone.Name)
  184. require.Equal(t, "", everyone.Hash)
  185. require.Equal(t, RoleAnonymous, everyone.Role)
  186. everyoneGrants, err := a.Grants(Everyone)
  187. require.Nil(t, err)
  188. require.Equal(t, []Grant{
  189. {"everyonewrite", PermissionReadWrite},
  190. {"announcements", PermissionRead},
  191. }, everyoneGrants)
  192. // Ben: Before revoking
  193. require.Nil(t, a.AllowAccess("ben", "mytopic", PermissionReadWrite)) // Overwrite!
  194. require.Nil(t, a.AllowAccess("ben", "readme", PermissionRead))
  195. require.Nil(t, a.AllowAccess("ben", "writeme", PermissionWrite))
  196. require.Nil(t, a.Authorize(ben, "mytopic", PermissionRead))
  197. require.Nil(t, a.Authorize(ben, "mytopic", PermissionWrite))
  198. require.Nil(t, a.Authorize(ben, "readme", PermissionRead))
  199. require.Nil(t, a.Authorize(ben, "writeme", PermissionWrite))
  200. // Revoke access for "ben" to "mytopic", then check again
  201. require.Nil(t, a.ResetAccess("ben", "mytopic"))
  202. require.Equal(t, ErrUnauthorized, a.Authorize(ben, "mytopic", PermissionWrite)) // Revoked
  203. require.Equal(t, ErrUnauthorized, a.Authorize(ben, "mytopic", PermissionRead)) // Revoked
  204. require.Nil(t, a.Authorize(ben, "readme", PermissionRead)) // Unchanged
  205. require.Nil(t, a.Authorize(ben, "writeme", PermissionWrite)) // Unchanged
  206. // Revoke rest of the access
  207. require.Nil(t, a.ResetAccess("ben", ""))
  208. require.Equal(t, ErrUnauthorized, a.Authorize(ben, "readme", PermissionRead)) // Revoked
  209. require.Equal(t, ErrUnauthorized, a.Authorize(ben, "wrtiteme", PermissionWrite)) // Revoked
  210. // User list
  211. users, err := a.Users()
  212. require.Nil(t, err)
  213. require.Equal(t, 3, len(users))
  214. require.Equal(t, "phil", users[0].Name)
  215. require.Equal(t, "ben", users[1].Name)
  216. require.Equal(t, "*", users[2].Name)
  217. // Remove user
  218. require.Nil(t, a.RemoveUser("ben"))
  219. _, err = a.User("ben")
  220. require.Equal(t, ErrUserNotFound, err)
  221. users, err = a.Users()
  222. require.Nil(t, err)
  223. require.Equal(t, 2, len(users))
  224. require.Equal(t, "phil", users[0].Name)
  225. require.Equal(t, "*", users[1].Name)
  226. }
  227. func TestManager_ChangePassword(t *testing.T) {
  228. a := newTestManager(t, PermissionDenyAll)
  229. require.Nil(t, a.AddUser("phil", "phil", RoleAdmin))
  230. _, err := a.Authenticate("phil", "phil")
  231. require.Nil(t, err)
  232. require.Nil(t, a.ChangePassword("phil", "newpass"))
  233. _, err = a.Authenticate("phil", "phil")
  234. require.Equal(t, ErrUnauthenticated, err)
  235. _, err = a.Authenticate("phil", "newpass")
  236. require.Nil(t, err)
  237. }
  238. func TestManager_ChangeRole(t *testing.T) {
  239. a := newTestManager(t, PermissionDenyAll)
  240. require.Nil(t, a.AddUser("ben", "ben", RoleUser))
  241. require.Nil(t, a.AllowAccess("ben", "mytopic", PermissionReadWrite))
  242. require.Nil(t, a.AllowAccess("ben", "readme", PermissionRead))
  243. ben, err := a.User("ben")
  244. require.Nil(t, err)
  245. require.Equal(t, RoleUser, ben.Role)
  246. benGrants, err := a.Grants("ben")
  247. require.Nil(t, err)
  248. require.Equal(t, 2, len(benGrants))
  249. require.Nil(t, a.ChangeRole("ben", RoleAdmin))
  250. ben, err = a.User("ben")
  251. require.Nil(t, err)
  252. require.Equal(t, RoleAdmin, ben.Role)
  253. benGrants, err = a.Grants("ben")
  254. require.Nil(t, err)
  255. require.Equal(t, 0, len(benGrants))
  256. }
  257. func TestManager_Reservations(t *testing.T) {
  258. a := newTestManager(t, PermissionDenyAll)
  259. require.Nil(t, a.AddUser("ben", "ben", RoleUser))
  260. require.Nil(t, a.AddReservation("ben", "ztopic", PermissionDenyAll))
  261. require.Nil(t, a.AddReservation("ben", "readme", PermissionRead))
  262. require.Nil(t, a.AllowAccess("ben", "something-else", PermissionRead))
  263. reservations, err := a.Reservations("ben")
  264. require.Nil(t, err)
  265. require.Equal(t, 2, len(reservations))
  266. require.Equal(t, Reservation{
  267. Topic: "readme",
  268. Owner: PermissionReadWrite,
  269. Everyone: PermissionRead,
  270. }, reservations[0])
  271. require.Equal(t, Reservation{
  272. Topic: "ztopic",
  273. Owner: PermissionReadWrite,
  274. Everyone: PermissionDenyAll,
  275. }, reservations[1])
  276. }
  277. func TestManager_ChangeRoleFromTierUserToAdmin(t *testing.T) {
  278. a := newTestManager(t, PermissionDenyAll)
  279. require.Nil(t, a.CreateTier(&Tier{
  280. Code: "pro",
  281. Name: "ntfy Pro",
  282. StripePriceID: "price123",
  283. MessageLimit: 5_000,
  284. MessageExpiryDuration: 3 * 24 * time.Hour,
  285. EmailLimit: 50,
  286. ReservationLimit: 5,
  287. AttachmentFileSizeLimit: 52428800,
  288. AttachmentTotalSizeLimit: 524288000,
  289. AttachmentExpiryDuration: 24 * time.Hour,
  290. }))
  291. require.Nil(t, a.AddUser("ben", "ben", RoleUser))
  292. require.Nil(t, a.ChangeTier("ben", "pro"))
  293. require.Nil(t, a.AddReservation("ben", "mytopic", PermissionDenyAll))
  294. ben, err := a.User("ben")
  295. require.Nil(t, err)
  296. require.Equal(t, RoleUser, ben.Role)
  297. require.Equal(t, "pro", ben.Tier.Code)
  298. require.Equal(t, int64(5000), ben.Tier.MessageLimit)
  299. require.Equal(t, 3*24*time.Hour, ben.Tier.MessageExpiryDuration)
  300. require.Equal(t, int64(50), ben.Tier.EmailLimit)
  301. require.Equal(t, int64(5), ben.Tier.ReservationLimit)
  302. require.Equal(t, int64(52428800), ben.Tier.AttachmentFileSizeLimit)
  303. require.Equal(t, int64(524288000), ben.Tier.AttachmentTotalSizeLimit)
  304. require.Equal(t, 24*time.Hour, ben.Tier.AttachmentExpiryDuration)
  305. benGrants, err := a.Grants("ben")
  306. require.Nil(t, err)
  307. require.Equal(t, 1, len(benGrants))
  308. require.Equal(t, PermissionReadWrite, benGrants[0].Allow)
  309. everyoneGrants, err := a.Grants(Everyone)
  310. require.Nil(t, err)
  311. require.Equal(t, 1, len(everyoneGrants))
  312. require.Equal(t, PermissionDenyAll, everyoneGrants[0].Allow)
  313. benReservations, err := a.Reservations("ben")
  314. require.Nil(t, err)
  315. require.Equal(t, 1, len(benReservations))
  316. require.Equal(t, "mytopic", benReservations[0].Topic)
  317. require.Equal(t, PermissionReadWrite, benReservations[0].Owner)
  318. require.Equal(t, PermissionDenyAll, benReservations[0].Everyone)
  319. // Switch to admin, this should remove all grants and owned ACL entries
  320. require.Nil(t, a.ChangeRole("ben", RoleAdmin))
  321. benGrants, err = a.Grants("ben")
  322. require.Nil(t, err)
  323. require.Equal(t, 0, len(benGrants))
  324. everyoneGrants, err = a.Grants(Everyone)
  325. require.Nil(t, err)
  326. require.Equal(t, 0, len(everyoneGrants))
  327. }
  328. func TestManager_Token_Valid(t *testing.T) {
  329. a := newTestManager(t, PermissionDenyAll)
  330. require.Nil(t, a.AddUser("ben", "ben", RoleUser))
  331. u, err := a.User("ben")
  332. require.Nil(t, err)
  333. // Create token for user
  334. token, err := a.CreateToken(u.ID, "some label", time.Now().Add(72*time.Hour))
  335. require.Nil(t, err)
  336. require.NotEmpty(t, token.Value)
  337. require.Equal(t, "some label", token.Label)
  338. require.True(t, time.Now().Add(71*time.Hour).Unix() < token.Expires.Unix())
  339. u2, err := a.AuthenticateToken(token.Value)
  340. require.Nil(t, err)
  341. require.Equal(t, u.Name, u2.Name)
  342. require.Equal(t, token.Value, u2.Token)
  343. token2, err := a.Token(u.ID, token.Value)
  344. require.Nil(t, err)
  345. require.Equal(t, token.Value, token2.Value)
  346. require.Equal(t, "some label", token2.Label)
  347. // Remove token and auth again
  348. require.Nil(t, a.RemoveToken(u2.ID, u2.Token))
  349. u3, err := a.AuthenticateToken(token.Value)
  350. require.Equal(t, ErrUnauthenticated, err)
  351. require.Nil(t, u3)
  352. }
  353. func TestManager_Token_Invalid(t *testing.T) {
  354. a := newTestManager(t, PermissionDenyAll)
  355. require.Nil(t, a.AddUser("ben", "ben", RoleUser))
  356. u, err := a.AuthenticateToken(strings.Repeat("x", 32)) // 32 == token length
  357. require.Nil(t, u)
  358. require.Equal(t, ErrUnauthenticated, err)
  359. u, err = a.AuthenticateToken("not long enough anyway")
  360. require.Nil(t, u)
  361. require.Equal(t, ErrUnauthenticated, err)
  362. }
  363. func TestManager_Token_Expire(t *testing.T) {
  364. a := newTestManager(t, PermissionDenyAll)
  365. require.Nil(t, a.AddUser("ben", "ben", RoleUser))
  366. u, err := a.User("ben")
  367. require.Nil(t, err)
  368. // Create tokens for user
  369. token1, err := a.CreateToken(u.ID, "", time.Now().Add(72*time.Hour))
  370. require.Nil(t, err)
  371. require.NotEmpty(t, token1.Value)
  372. require.True(t, time.Now().Add(71*time.Hour).Unix() < token1.Expires.Unix())
  373. token2, err := a.CreateToken(u.ID, "", time.Now().Add(72*time.Hour))
  374. require.Nil(t, err)
  375. require.NotEmpty(t, token2.Value)
  376. require.NotEqual(t, token1.Value, token2.Value)
  377. require.True(t, time.Now().Add(71*time.Hour).Unix() < token2.Expires.Unix())
  378. // See that tokens work
  379. _, err = a.AuthenticateToken(token1.Value)
  380. require.Nil(t, err)
  381. _, err = a.AuthenticateToken(token2.Value)
  382. require.Nil(t, err)
  383. // Modify token expiration in database
  384. _, err = a.db.Exec("UPDATE user_token SET expires = 1 WHERE token = ?", token1.Value)
  385. require.Nil(t, err)
  386. // Now token1 shouldn't work anymore
  387. _, err = a.AuthenticateToken(token1.Value)
  388. require.Equal(t, ErrUnauthenticated, err)
  389. result, err := a.db.Query("SELECT * from user_token WHERE token = ?", token1.Value)
  390. require.Nil(t, err)
  391. require.True(t, result.Next()) // Still a matching row
  392. require.Nil(t, result.Close())
  393. // Expire tokens and check database rows
  394. require.Nil(t, a.RemoveExpiredTokens())
  395. result, err = a.db.Query("SELECT * from user_token WHERE token = ?", token1.Value)
  396. require.Nil(t, err)
  397. require.False(t, result.Next()) // No matching row!
  398. require.Nil(t, result.Close())
  399. }
  400. func TestManager_Token_Extend(t *testing.T) {
  401. a := newTestManager(t, PermissionDenyAll)
  402. require.Nil(t, a.AddUser("ben", "ben", RoleUser))
  403. // Try to extend token for user without token
  404. u, err := a.User("ben")
  405. require.Nil(t, err)
  406. _, err = a.ChangeToken(u.ID, u.Token, util.String("some label"), util.Time(time.Now().Add(time.Hour)))
  407. require.Equal(t, errNoTokenProvided, err)
  408. // Create token for user
  409. token, err := a.CreateToken(u.ID, "", time.Now().Add(72*time.Hour))
  410. require.Nil(t, err)
  411. require.NotEmpty(t, token.Value)
  412. userWithToken, err := a.AuthenticateToken(token.Value)
  413. require.Nil(t, err)
  414. extendedToken, err := a.ChangeToken(userWithToken.ID, userWithToken.Token, util.String("changed label"), util.Time(time.Now().Add(100*time.Hour)))
  415. require.Nil(t, err)
  416. require.Equal(t, token.Value, extendedToken.Value)
  417. require.Equal(t, "changed label", extendedToken.Label)
  418. require.True(t, token.Expires.Unix() < extendedToken.Expires.Unix())
  419. require.True(t, time.Now().Add(99*time.Hour).Unix() < extendedToken.Expires.Unix())
  420. }
  421. func TestManager_Token_MaxCount_AutoDelete(t *testing.T) {
  422. a := newTestManager(t, PermissionDenyAll)
  423. require.Nil(t, a.AddUser("ben", "ben", RoleUser))
  424. // Try to extend token for user without token
  425. u, err := a.User("ben")
  426. require.Nil(t, err)
  427. // Tokens
  428. baseTime := time.Now().Add(24 * time.Hour)
  429. tokens := make([]string, 0)
  430. for i := 0; i < 12; i++ {
  431. token, err := a.CreateToken(u.ID, "", time.Now().Add(72*time.Hour))
  432. require.Nil(t, err)
  433. require.NotEmpty(t, token.Value)
  434. tokens = append(tokens, token.Value)
  435. // Manually modify expiry date to avoid sorting issues (this is a hack)
  436. _, err = a.db.Exec(`UPDATE user_token SET expires=? WHERE token=?`, baseTime.Add(time.Duration(i)*time.Minute).Unix(), token.Value)
  437. require.Nil(t, err)
  438. }
  439. _, err = a.AuthenticateToken(tokens[0])
  440. require.Equal(t, ErrUnauthenticated, err)
  441. _, err = a.AuthenticateToken(tokens[1])
  442. require.Equal(t, ErrUnauthenticated, err)
  443. for i := 2; i < 12; i++ {
  444. userWithToken, err := a.AuthenticateToken(tokens[i])
  445. require.Nil(t, err, "token[%d]=%s failed", i, tokens[i])
  446. require.Equal(t, "ben", userWithToken.Name)
  447. require.Equal(t, tokens[i], userWithToken.Token)
  448. }
  449. var count int
  450. rows, err := a.db.Query(`SELECT COUNT(*) FROM user_token`)
  451. require.Nil(t, err)
  452. require.True(t, rows.Next())
  453. require.Nil(t, rows.Scan(&count))
  454. require.Equal(t, 10, count)
  455. }
  456. func TestManager_EnqueueStats(t *testing.T) {
  457. a, err := NewManager(filepath.Join(t.TempDir(), "db"), "", PermissionReadWrite, bcrypt.MinCost, 1500*time.Millisecond)
  458. require.Nil(t, err)
  459. require.Nil(t, a.AddUser("ben", "ben", RoleUser))
  460. // Baseline: No messages or emails
  461. u, err := a.User("ben")
  462. require.Nil(t, err)
  463. require.Equal(t, int64(0), u.Stats.Messages)
  464. require.Equal(t, int64(0), u.Stats.Emails)
  465. a.EnqueueStats(u.ID, &Stats{
  466. Messages: 11,
  467. Emails: 2,
  468. })
  469. // Still no change, because it's queued asynchronously
  470. u, err = a.User("ben")
  471. require.Nil(t, err)
  472. require.Equal(t, int64(0), u.Stats.Messages)
  473. require.Equal(t, int64(0), u.Stats.Emails)
  474. // After 2 seconds they should be persisted
  475. time.Sleep(2 * time.Second)
  476. u, err = a.User("ben")
  477. require.Nil(t, err)
  478. require.Equal(t, int64(11), u.Stats.Messages)
  479. require.Equal(t, int64(2), u.Stats.Emails)
  480. }
  481. func TestManager_ChangeSettings(t *testing.T) {
  482. a, err := NewManager(filepath.Join(t.TempDir(), "db"), "", PermissionReadWrite, bcrypt.MinCost, 1500*time.Millisecond)
  483. require.Nil(t, err)
  484. require.Nil(t, a.AddUser("ben", "ben", RoleUser))
  485. // No settings
  486. u, err := a.User("ben")
  487. require.Nil(t, err)
  488. require.Nil(t, u.Prefs.Subscriptions)
  489. require.Nil(t, u.Prefs.Notification)
  490. require.Nil(t, u.Prefs.Language)
  491. // Save with new settings
  492. u.Prefs = &Prefs{
  493. Language: util.String("de"),
  494. Notification: &NotificationPrefs{
  495. Sound: util.String("ding"),
  496. MinPriority: util.Int(2),
  497. },
  498. Subscriptions: []*Subscription{
  499. {
  500. ID: "someID",
  501. BaseURL: "https://ntfy.sh",
  502. Topic: "mytopic",
  503. DisplayName: util.String("My Topic"),
  504. },
  505. },
  506. }
  507. require.Nil(t, a.ChangeSettings(u))
  508. // Read again
  509. u, err = a.User("ben")
  510. require.Nil(t, err)
  511. require.Equal(t, util.String("de"), u.Prefs.Language)
  512. require.Equal(t, util.String("ding"), u.Prefs.Notification.Sound)
  513. require.Equal(t, util.Int(2), u.Prefs.Notification.MinPriority)
  514. require.Nil(t, u.Prefs.Notification.DeleteAfter)
  515. require.Equal(t, "someID", u.Prefs.Subscriptions[0].ID)
  516. require.Equal(t, "https://ntfy.sh", u.Prefs.Subscriptions[0].BaseURL)
  517. require.Equal(t, "mytopic", u.Prefs.Subscriptions[0].Topic)
  518. require.Equal(t, util.String("My Topic"), u.Prefs.Subscriptions[0].DisplayName)
  519. }
  520. func TestSqliteCache_Migration_From1(t *testing.T) {
  521. filename := filepath.Join(t.TempDir(), "user.db")
  522. db, err := sql.Open("sqlite3", filename)
  523. require.Nil(t, err)
  524. // Create "version 1" schema
  525. _, err = db.Exec(`
  526. BEGIN;
  527. CREATE TABLE IF NOT EXISTS user (
  528. user TEXT NOT NULL PRIMARY KEY,
  529. pass TEXT NOT NULL,
  530. role TEXT NOT NULL
  531. );
  532. CREATE TABLE IF NOT EXISTS access (
  533. user TEXT NOT NULL,
  534. topic TEXT NOT NULL,
  535. read INT NOT NULL,
  536. write INT NOT NULL,
  537. PRIMARY KEY (topic, user)
  538. );
  539. CREATE TABLE IF NOT EXISTS schemaVersion (
  540. id INT PRIMARY KEY,
  541. version INT NOT NULL
  542. );
  543. INSERT INTO schemaVersion (id, version) VALUES (1, 1);
  544. COMMIT;
  545. `)
  546. require.Nil(t, err)
  547. // Insert a bunch of users and ACL entries
  548. _, err = db.Exec(`
  549. BEGIN;
  550. INSERT INTO user (user, pass, role) VALUES ('ben', '$2a$10$EEp6gBheOsqEFsXlo523E.gBVoeg1ytphXiEvTPlNzkenBlHZBPQy', 'user');
  551. INSERT INTO user (user, pass, role) VALUES ('phil', '$2a$10$YLiO8U21sX1uhZamTLJXHuxgVC0Z/GKISibrKCLohPgtG7yIxSk4C', 'admin');
  552. INSERT INTO access (user, topic, read, write) VALUES ('ben', 'stats', 1, 1);
  553. INSERT INTO access (user, topic, read, write) VALUES ('ben', 'secret', 1, 0);
  554. INSERT INTO access (user, topic, read, write) VALUES ('*', 'stats', 1, 0);
  555. COMMIT;
  556. `)
  557. require.Nil(t, err)
  558. // Create manager to trigger migration
  559. a := newTestManagerFromFile(t, filename, "", PermissionDenyAll, bcrypt.MinCost, DefaultUserStatsQueueWriterInterval)
  560. checkSchemaVersion(t, a.db)
  561. users, err := a.Users()
  562. require.Nil(t, err)
  563. require.Equal(t, 3, len(users))
  564. phil, ben, everyone := users[0], users[1], users[2]
  565. philGrants, err := a.Grants("phil")
  566. require.Nil(t, err)
  567. benGrants, err := a.Grants("ben")
  568. require.Nil(t, err)
  569. everyoneGrants, err := a.Grants(Everyone)
  570. require.Nil(t, err)
  571. require.True(t, strings.HasPrefix(phil.ID, "u_"))
  572. require.Equal(t, "phil", phil.Name)
  573. require.Equal(t, RoleAdmin, phil.Role)
  574. require.Equal(t, syncTopicLength, len(phil.SyncTopic))
  575. require.Equal(t, 0, len(philGrants))
  576. require.True(t, strings.HasPrefix(ben.ID, "u_"))
  577. require.NotEqual(t, phil.ID, ben.ID)
  578. require.Equal(t, "ben", ben.Name)
  579. require.Equal(t, RoleUser, ben.Role)
  580. require.Equal(t, syncTopicLength, len(ben.SyncTopic))
  581. require.NotEqual(t, ben.SyncTopic, phil.SyncTopic)
  582. require.Equal(t, 2, len(benGrants))
  583. require.Equal(t, "stats", benGrants[0].TopicPattern)
  584. require.Equal(t, PermissionReadWrite, benGrants[0].Allow)
  585. require.Equal(t, "secret", benGrants[1].TopicPattern)
  586. require.Equal(t, PermissionRead, benGrants[1].Allow)
  587. require.Equal(t, "u_everyone", everyone.ID)
  588. require.Equal(t, Everyone, everyone.Name)
  589. require.Equal(t, RoleAnonymous, everyone.Role)
  590. require.Equal(t, 1, len(everyoneGrants))
  591. require.Equal(t, "stats", everyoneGrants[0].TopicPattern)
  592. require.Equal(t, PermissionRead, everyoneGrants[0].Allow)
  593. }
  594. func checkSchemaVersion(t *testing.T, db *sql.DB) {
  595. rows, err := db.Query(`SELECT version FROM schemaVersion`)
  596. require.Nil(t, err)
  597. require.True(t, rows.Next())
  598. var schemaVersion int
  599. require.Nil(t, rows.Scan(&schemaVersion))
  600. require.Equal(t, currentSchemaVersion, schemaVersion)
  601. require.Nil(t, rows.Close())
  602. }
  603. func newTestManager(t *testing.T, defaultAccess Permission) *Manager {
  604. return newTestManagerFromFile(t, filepath.Join(t.TempDir(), "user.db"), "", defaultAccess, bcrypt.MinCost, DefaultUserStatsQueueWriterInterval)
  605. }
  606. func newTestManagerFromFile(t *testing.T, filename, startupQueries string, defaultAccess Permission, bcryptCost int, statsWriterInterval time.Duration) *Manager {
  607. a, err := NewManager(filename, startupQueries, defaultAccess, bcryptCost, statsWriterInterval)
  608. require.Nil(t, err)
  609. return a
  610. }