Sfoglia il codice sorgente

write http errors to websocket connection instead of always 200

Hunter Kehoe 9 mesi fa
parent
commit
cdae5493e2
1 ha cambiato i file con 2 aggiunte e 1 eliminazioni
  1. 2 1
      server/server.go

+ 2 - 1
server/server.go

@@ -413,7 +413,8 @@ func (s *Server) handleError(w http.ResponseWriter, r *http.Request, v *visitor,
 		} else {
 			ev.Info("WebSocket error: %s", err.Error())
 		}
-		return // Do not attempt to write to upgraded connection
+		w.WriteHeader(httpErr.HTTPCode)
+		return // Do not attempt to write any body to upgraded connection
 	}
 	if isNormalError {
 		ev.Debug("Connection closed with HTTP %d (ntfy error %d)", httpErr.HTTPCode, httpErr.Code)