binwiederhier 3 лет назад
Родитель
Сommit
67221b015d
2 измененных файлов с 5 добавлено и 6 удалено
  1. 2 0
      docs/releases.md
  2. 3 6
      server/message_cache.go

+ 2 - 0
docs/releases.md

@@ -7,10 +7,12 @@ and the [ntfy Android app](https://github.com/binwiederhier/ntfy-android/release
 **Features:**
 
 * Web: Generate random topic name button ([#453](https://github.com/binwiederhier/ntfy/issues/453), thanks to [@yardenshoham](https://github.com/yardenshoham))
+* Add [Gitpod config](https://github.com/binwiederhier/ntfy/blob/main/.gitpod.yml) ([#540](https://github.com/binwiederhier/ntfy/pull/540), thanks to [@yardenshoham](https://github.com/yardenshoham)) 
 
 **Bug fixes + maintenance:**
 
 * Remove `--env-topic` option from `ntfy publish` as per [deprecation](deprecations.md) (no ticket)
+* Prepared statements for message cache writes ([#542](https://github.com/binwiederhier/ntfy/pull/542), thanks to [@nicois](https://github.com/nicois))
 
 ## ntfy Android app v1.16.0
 Released December 11, 2022

+ 3 - 6
server/message_cache.go

@@ -267,14 +267,11 @@ func (c *messageCache) addMessages(ms []*message) error {
 		return err
 	}
 	defer tx.Rollback()
-	statement, err := tx.Prepare(
-		insertMessageQuery,
-	)
+	stmt, err := tx.Prepare(insertMessageQuery)
 	if err != nil {
 		return err
 	}
-	defer statement.Close()
-
+	defer stmt.Close()
 	for _, m := range ms {
 		if m.Event != messageEvent {
 			return errUnexpectedMessageType
@@ -302,7 +299,7 @@ func (c *messageCache) addMessages(ms []*message) error {
 		if m.Sender.IsValid() {
 			sender = m.Sender.String()
 		}
-		_, err := statement.Exec(
+		_, err := stmt.Exec(
 			m.ID,
 			m.Time,
 			m.Topic,