filter.rs 13 KB

123456789101112131415161718192021222324252627282930313233343536373839404142434445464748495051525354555657585960616263646566676869707172737475767778798081828384858687888990919293949596979899100101102103104105106107108109110111112113114115116117118119120121122123124125126127128129130131132133134135136137138139140141142143144145146147148149150151152153154155156157158159160161162163164165166167168169170171172173174175176177178179180181182183184185186187188189190191192193194195196197198199200201202203204205206207208209210211212213214215216217218219220221222223224225226227228229230231232233234235236237238239240241242243244245246247248249250251252253254255256257258259260261262263264265266267268269270271272273274275276277278279280281282283284285286287288289290291292293294295296297298299300301302303304305306307308309310311312313314315316317318319320321322323324
  1. //! Parsing the options for `FileFilter`.
  2. use crate::fs::DotFilter;
  3. use crate::fs::filter::{FileFilter, SortField, SortCase, IgnorePatterns, GitIgnore};
  4. use crate::options::{flags, OptionsError};
  5. use crate::options::parser::MatchedFlags;
  6. impl FileFilter {
  7. /// Determines which of all the file filter options to use.
  8. pub fn deduce(matches: &MatchedFlags<'_>) -> Result<Self, OptionsError> {
  9. Ok(Self {
  10. list_dirs_first: matches.has(&flags::DIRS_FIRST)?,
  11. reverse: matches.has(&flags::REVERSE)?,
  12. only_dirs: matches.has(&flags::ONLY_DIRS)?,
  13. sort_field: SortField::deduce(matches)?,
  14. dot_filter: DotFilter::deduce(matches)?,
  15. ignore_patterns: IgnorePatterns::deduce(matches)?,
  16. git_ignore: GitIgnore::deduce(matches)?,
  17. })
  18. }
  19. }
  20. impl SortField {
  21. /// Determines which sort field to use based on the `--sort` argument.
  22. /// This argument’s value can be one of several flags, listed above.
  23. /// Returns the default sort field if none is given, or `Err` if the
  24. /// value doesn’t correspond to a sort field we know about.
  25. fn deduce(matches: &MatchedFlags<'_>) -> Result<Self, OptionsError> {
  26. let word = match matches.get(&flags::SORT)? {
  27. Some(w) => w,
  28. None => return Ok(Self::default()),
  29. };
  30. // Get String because we can’t match an OsStr
  31. let word = match word.to_str() {
  32. Some(w) => w,
  33. None => return Err(OptionsError::BadArgument(&flags::SORT, word.into()))
  34. };
  35. let field = match word {
  36. "name" | "filename" => {
  37. Self::Name(SortCase::AaBbCc)
  38. }
  39. "Name" | "Filename" => {
  40. Self::Name(SortCase::ABCabc)
  41. }
  42. ".name" | ".filename" => {
  43. Self::NameMixHidden(SortCase::AaBbCc)
  44. }
  45. ".Name" | ".Filename" => {
  46. Self::NameMixHidden(SortCase::ABCabc)
  47. }
  48. "size" | "filesize" => {
  49. Self::Size
  50. }
  51. "ext" | "extension" => {
  52. Self::Extension(SortCase::AaBbCc)
  53. }
  54. "Ext" | "Extension" => {
  55. Self::Extension(SortCase::ABCabc)
  56. }
  57. // “new” sorts oldest at the top and newest at the bottom; “old”
  58. // sorts newest at the top and oldest at the bottom. I think this
  59. // is the right way round to do this: “size” puts the smallest at
  60. // the top and the largest at the bottom, doesn’t it?
  61. "date" | "time" | "mod" | "modified" | "new" | "newest" => {
  62. Self::ModifiedDate
  63. }
  64. // Similarly, “age” means that files with the least age (the
  65. // newest files) get sorted at the top, and files with the most
  66. // age (the oldest) at the bottom.
  67. "age" | "old" | "oldest" => {
  68. Self::ModifiedAge
  69. }
  70. "ch" | "changed" => {
  71. Self::ChangedDate
  72. }
  73. "acc" | "accessed" => {
  74. Self::AccessedDate
  75. }
  76. "cr" | "created" => {
  77. Self::CreatedDate
  78. }
  79. #[cfg(unix)]
  80. "inode" => {
  81. Self::FileInode
  82. }
  83. "type" => {
  84. Self::FileType
  85. }
  86. "none" => {
  87. Self::Unsorted
  88. }
  89. _ => {
  90. return Err(OptionsError::BadArgument(&flags::SORT, word.into()));
  91. }
  92. };
  93. Ok(field)
  94. }
  95. }
  96. // I’ve gone back and forth between whether to sort case-sensitively or
  97. // insensitively by default. The default string sort in most programming
  98. // languages takes each character’s ASCII value into account, sorting
  99. // “Documents” before “apps”, but there’s usually an option to ignore
  100. // characters’ case, putting “apps” before “Documents”.
  101. //
  102. // The argument for following case is that it’s easy to forget whether an item
  103. // begins with an uppercase or lowercase letter and end up having to scan both
  104. // the uppercase and lowercase sub-lists to find the item you want. If you
  105. // happen to pick the sublist it’s not in, it looks like it’s missing, which
  106. // is worse than if you just take longer to find it.
  107. // (https://ux.stackexchange.com/a/79266)
  108. //
  109. // The argument for ignoring case is that it makes exa sort files differently
  110. // from shells. A user would expect a directory’s files to be in the same
  111. // order if they used “exa ~/directory” or “exa ~/directory/*”, but exa sorts
  112. // them in the first case, and the shell in the second case, so they wouldn’t
  113. // be exactly the same if exa does something non-conventional.
  114. //
  115. // However, exa already sorts files differently: it uses natural sorting from
  116. // the natord crate, sorting the string “2” before “10” because the number’s
  117. // smaller, because that’s usually what the user expects to happen. Users will
  118. // name their files with numbers expecting them to be treated like numbers,
  119. // rather than lists of numeric characters.
  120. //
  121. // In the same way, users will name their files with letters expecting the
  122. // order of the letters to matter, rather than each letter’s character’s ASCII
  123. // value. So exa breaks from tradition and ignores case while sorting:
  124. // “apps” first, then “Documents”.
  125. //
  126. // You can get the old behaviour back by sorting with `--sort=Name`.
  127. impl Default for SortField {
  128. fn default() -> Self {
  129. Self::Name(SortCase::AaBbCc)
  130. }
  131. }
  132. impl DotFilter {
  133. /// Determines the dot filter based on how many `--all` options were
  134. /// given: one will show dotfiles, but two will show `.` and `..` too.
  135. ///
  136. /// It also checks for the `--tree` option in strict mode, because of a
  137. /// special case where `--tree --all --all` won’t work: listing the
  138. /// parent directory in tree mode would loop onto itself!
  139. pub fn deduce(matches: &MatchedFlags<'_>) -> Result<Self, OptionsError> {
  140. let count = matches.count(&flags::ALL);
  141. if count == 0 {
  142. Ok(Self::JustFiles)
  143. }
  144. else if count == 1 {
  145. Ok(Self::Dotfiles)
  146. }
  147. else if matches.count(&flags::TREE) > 0 {
  148. Err(OptionsError::TreeAllAll)
  149. }
  150. else if count >= 3 && matches.is_strict() {
  151. Err(OptionsError::Conflict(&flags::ALL, &flags::ALL))
  152. }
  153. else {
  154. Ok(Self::DotfilesAndDots)
  155. }
  156. }
  157. }
  158. impl IgnorePatterns {
  159. /// Determines the set of glob patterns to use based on the
  160. /// `--ignore-glob` argument’s value. This is a list of strings
  161. /// separated by pipe (`|`) characters, given in any order.
  162. pub fn deduce(matches: &MatchedFlags<'_>) -> Result<Self, OptionsError> {
  163. // If there are no inputs, we return a set of patterns that doesn’t
  164. // match anything, rather than, say, `None`.
  165. let inputs = match matches.get(&flags::IGNORE_GLOB)? {
  166. Some(is) => is,
  167. None => return Ok(Self::empty()),
  168. };
  169. // Awkwardly, though, a glob pattern can be invalid, and we need to
  170. // deal with invalid patterns somehow.
  171. let (patterns, mut errors) = Self::parse_from_iter(inputs.to_string_lossy().split('|'));
  172. // It can actually return more than one glob error,
  173. // but we only use one. (TODO)
  174. match errors.pop() {
  175. Some(e) => Err(e.into()),
  176. None => Ok(patterns),
  177. }
  178. }
  179. }
  180. impl GitIgnore {
  181. pub fn deduce(matches: &MatchedFlags<'_>) -> Result<Self, OptionsError> {
  182. if matches.has(&flags::GIT_IGNORE)? {
  183. Ok(Self::CheckAndIgnore)
  184. }
  185. else {
  186. Ok(Self::Off)
  187. }
  188. }
  189. }
  190. #[cfg(test)]
  191. mod test {
  192. use super::*;
  193. use std::ffi::OsString;
  194. use crate::options::flags;
  195. use crate::options::parser::Flag;
  196. macro_rules! test {
  197. ($name:ident: $type:ident <- $inputs:expr; $stricts:expr => $result:expr) => {
  198. #[test]
  199. fn $name() {
  200. use crate::options::parser::Arg;
  201. use crate::options::test::parse_for_test;
  202. use crate::options::test::Strictnesses::*;
  203. static TEST_ARGS: &[&Arg] = &[ &flags::SORT, &flags::ALL, &flags::TREE, &flags::IGNORE_GLOB, &flags::GIT_IGNORE ];
  204. for result in parse_for_test($inputs.as_ref(), TEST_ARGS, $stricts, |mf| $type::deduce(mf)) {
  205. assert_eq!(result, $result);
  206. }
  207. }
  208. };
  209. }
  210. mod sort_fields {
  211. use super::*;
  212. // Default behaviour
  213. test!(empty: SortField <- []; Both => Ok(SortField::default()));
  214. // Sort field arguments
  215. test!(one_arg: SortField <- ["--sort=mod"]; Both => Ok(SortField::ModifiedDate));
  216. test!(one_long: SortField <- ["--sort=size"]; Both => Ok(SortField::Size));
  217. test!(one_short: SortField <- ["-saccessed"]; Both => Ok(SortField::AccessedDate));
  218. test!(lowercase: SortField <- ["--sort", "name"]; Both => Ok(SortField::Name(SortCase::AaBbCc)));
  219. test!(uppercase: SortField <- ["--sort", "Name"]; Both => Ok(SortField::Name(SortCase::ABCabc)));
  220. test!(old: SortField <- ["--sort", "new"]; Both => Ok(SortField::ModifiedDate));
  221. test!(oldest: SortField <- ["--sort=newest"]; Both => Ok(SortField::ModifiedDate));
  222. test!(new: SortField <- ["--sort", "old"]; Both => Ok(SortField::ModifiedAge));
  223. test!(newest: SortField <- ["--sort=oldest"]; Both => Ok(SortField::ModifiedAge));
  224. test!(age: SortField <- ["-sage"]; Both => Ok(SortField::ModifiedAge));
  225. test!(mix_hidden_lowercase: SortField <- ["--sort", ".name"]; Both => Ok(SortField::NameMixHidden(SortCase::AaBbCc)));
  226. test!(mix_hidden_uppercase: SortField <- ["--sort", ".Name"]; Both => Ok(SortField::NameMixHidden(SortCase::ABCabc)));
  227. // Errors
  228. test!(error: SortField <- ["--sort=colour"]; Both => Err(OptionsError::BadArgument(&flags::SORT, OsString::from("colour"))));
  229. // Overriding
  230. test!(overridden: SortField <- ["--sort=cr", "--sort", "mod"]; Last => Ok(SortField::ModifiedDate));
  231. test!(overridden_2: SortField <- ["--sort", "none", "--sort=Extension"]; Last => Ok(SortField::Extension(SortCase::ABCabc)));
  232. test!(overridden_3: SortField <- ["--sort=cr", "--sort", "mod"]; Complain => Err(OptionsError::Duplicate(Flag::Long("sort"), Flag::Long("sort"))));
  233. test!(overridden_4: SortField <- ["--sort", "none", "--sort=Extension"]; Complain => Err(OptionsError::Duplicate(Flag::Long("sort"), Flag::Long("sort"))));
  234. }
  235. mod dot_filters {
  236. use super::*;
  237. // Default behaviour
  238. test!(empty: DotFilter <- []; Both => Ok(DotFilter::JustFiles));
  239. // --all
  240. test!(all: DotFilter <- ["--all"]; Both => Ok(DotFilter::Dotfiles));
  241. test!(all_all: DotFilter <- ["--all", "-a"]; Both => Ok(DotFilter::DotfilesAndDots));
  242. test!(all_all_2: DotFilter <- ["-aa"]; Both => Ok(DotFilter::DotfilesAndDots));
  243. test!(all_all_3: DotFilter <- ["-aaa"]; Last => Ok(DotFilter::DotfilesAndDots));
  244. test!(all_all_4: DotFilter <- ["-aaa"]; Complain => Err(OptionsError::Conflict(&flags::ALL, &flags::ALL)));
  245. // --all and --tree
  246. test!(tree_a: DotFilter <- ["-Ta"]; Both => Ok(DotFilter::Dotfiles));
  247. test!(tree_aa: DotFilter <- ["-Taa"]; Both => Err(OptionsError::TreeAllAll));
  248. test!(tree_aaa: DotFilter <- ["-Taaa"]; Both => Err(OptionsError::TreeAllAll));
  249. }
  250. mod ignore_patterns {
  251. use super::*;
  252. use std::iter::FromIterator;
  253. fn pat(string: &'static str) -> glob::Pattern {
  254. glob::Pattern::new(string).unwrap()
  255. }
  256. // Various numbers of globs
  257. test!(none: IgnorePatterns <- []; Both => Ok(IgnorePatterns::empty()));
  258. test!(one: IgnorePatterns <- ["--ignore-glob", "*.ogg"]; Both => Ok(IgnorePatterns::from_iter(vec![ pat("*.ogg") ])));
  259. test!(two: IgnorePatterns <- ["--ignore-glob=*.ogg|*.MP3"]; Both => Ok(IgnorePatterns::from_iter(vec![ pat("*.ogg"), pat("*.MP3") ])));
  260. test!(loads: IgnorePatterns <- ["-I*|?|.|*"]; Both => Ok(IgnorePatterns::from_iter(vec![ pat("*"), pat("?"), pat("."), pat("*") ])));
  261. // Overriding
  262. test!(overridden: IgnorePatterns <- ["-I=*.ogg", "-I", "*.mp3"]; Last => Ok(IgnorePatterns::from_iter(vec![ pat("*.mp3") ])));
  263. test!(overridden_2: IgnorePatterns <- ["-I", "*.OGG", "-I*.MP3"]; Last => Ok(IgnorePatterns::from_iter(vec![ pat("*.MP3") ])));
  264. test!(overridden_3: IgnorePatterns <- ["-I=*.ogg", "-I", "*.mp3"]; Complain => Err(OptionsError::Duplicate(Flag::Short(b'I'), Flag::Short(b'I'))));
  265. test!(overridden_4: IgnorePatterns <- ["-I", "*.OGG", "-I*.MP3"]; Complain => Err(OptionsError::Duplicate(Flag::Short(b'I'), Flag::Short(b'I'))));
  266. }
  267. mod git_ignores {
  268. use super::*;
  269. test!(off: GitIgnore <- []; Both => Ok(GitIgnore::Off));
  270. test!(on: GitIgnore <- ["--git-ignore"]; Both => Ok(GitIgnore::CheckAndIgnore));
  271. }
  272. }