浏览代码

Simplify boolean assertions in tests

Victor Song 3 年之前
父节点
当前提交
72b2119a34
共有 3 个文件被更改,包括 12 次插入12 次删除
  1. 8 8
      src/fs/filter.rs
  2. 1 1
      src/options/parser.rs
  3. 3 3
      src/output/tree.rs

+ 8 - 8
src/fs/filter.rs

@@ -346,31 +346,31 @@ mod test_ignores {
     #[test]
     fn empty_matches_nothing() {
         let pats = IgnorePatterns::empty();
-        assert_eq!(false, pats.is_ignored("nothing"));
-        assert_eq!(false, pats.is_ignored("test.mp3"));
+        assert!(!pats.is_ignored("nothing"));
+        assert!(!pats.is_ignored("test.mp3"));
     }
 
     #[test]
     fn ignores_a_glob() {
         let (pats, fails) = IgnorePatterns::parse_from_iter(vec![ "*.mp3" ]);
         assert!(fails.is_empty());
-        assert_eq!(false, pats.is_ignored("nothing"));
-        assert_eq!(true,  pats.is_ignored("test.mp3"));
+        assert!(!pats.is_ignored("nothing"));
+        assert!(pats.is_ignored("test.mp3"));
     }
 
     #[test]
     fn ignores_an_exact_filename() {
         let (pats, fails) = IgnorePatterns::parse_from_iter(vec![ "nothing" ]);
         assert!(fails.is_empty());
-        assert_eq!(true,  pats.is_ignored("nothing"));
-        assert_eq!(false, pats.is_ignored("test.mp3"));
+        assert!(pats.is_ignored("nothing"));
+        assert!(!pats.is_ignored("test.mp3"));
     }
 
     #[test]
     fn ignores_both() {
         let (pats, fails) = IgnorePatterns::parse_from_iter(vec![ "nothing", "*.mp3" ]);
         assert!(fails.is_empty());
-        assert_eq!(true, pats.is_ignored("nothing"));
-        assert_eq!(true, pats.is_ignored("test.mp3"));
+        assert!(pats.is_ignored("nothing"));
+        assert!(pats.is_ignored("test.mp3"));
     }
 }

+ 1 - 1
src/options/parser.rs

@@ -743,6 +743,6 @@ mod matches_test {
     fn no_count() {
         let flags = MatchedFlags { flags: Vec::new(), strictness: Strictness::UseLastArguments };
 
-        assert_eq!(flags.has(&COUNT).unwrap(), false);
+        assert!(!flags.has(&COUNT).unwrap());
     }
 }

+ 3 - 3
src/output/tree.rs

@@ -257,15 +257,15 @@ mod iter_test {
 
         let next = iter.next().unwrap();
         assert_eq!(&"first", next.1);
-        assert_eq!(false, next.0.last);
+        assert!(!next.0.last);
 
         let next = iter.next().unwrap();
         assert_eq!(&"middle", next.1);
-        assert_eq!(false, next.0.last);
+        assert!(!next.0.last);
 
         let next = iter.next().unwrap();
         assert_eq!(&"last", next.1);
-        assert_eq!(true, next.0.last);
+        assert!(next.0.last);
 
         assert!(iter.next().is_none());
     }