Răsfoiți Sursa

better handling of ignored errors

Gildas 6 ani în urmă
părinte
comite
2f96827e55
2 a modificat fișierele cu 4 adăugiri și 12 ștergeri
  1. 3 7
      extension/core/bg/autosave.js
  2. 1 5
      extension/ui/bg/ui-menu.js

+ 3 - 7
extension/core/bg/autosave.js

@@ -73,14 +73,10 @@ singlefile.autosave = (() => {
 	}
 
 	async function refreshTabs() {
-		const tabs = await singlefile.tabs.get({});
+		const tabs = (await singlefile.tabs.get({})).filter(tab => singlefile.util.isAllowedURL(tab.url));
 		return Promise.all(tabs.map(async tab => {
-			try {
-				const [options, autoSaveEnabled] = await Promise.all([singlefile.config.getOptions(tab.url, true), isEnabled(tab)]);
-				await singlefile.tabs.sendMessage(tab.id, { method: "content.init", autoSaveEnabled, options });
-			} catch (error) {
-				console.log("Content script not injected", "tab #" + tab.id, error); // eslint-disable-line no-console
-			}
+			const [options, autoSaveEnabled] = await Promise.all([singlefile.config.getOptions(tab.url, true), isEnabled(tab)]);
+			singlefile.tabs.sendMessage(tab.id, { method: "content.init", autoSaveEnabled, options }).catch(() => { /* ignored */ });
 		}));
 	}
 

+ 1 - 5
extension/ui/bg/ui-menu.js

@@ -364,11 +364,7 @@ singlefile.ui.menu = (() => {
 		const tabsData = await singlefile.tabsData.get(tab.id);
 		await singlefile.autosave.refreshTabs();
 		singlefile.ui.button.refresh(tab, options);
-		try {
-			await browser.runtime.sendMessage({ method: "options.refresh", profileName: tabsData.profileName });
-		} catch (error) {
-			console.log("Options page not displayed", error); // eslint-disable-line no-console
-		}
+		browser.runtime.sendMessage({ method: "options.refresh", profileName: tabsData.profileName }).catch(() => { /* ignored */ });
 	}
 
 	async function refreshTab(tab) {