瀏覽代碼

Always test bcrypt

Unrud 3 年之前
父節點
當前提交
5aa2f59b38
共有 3 個文件被更改,包括 4 次插入16 次删除
  1. 0 10
      radicale/tests/test_auth.py
  2. 1 3
      setup.cfg
  3. 3 3
      setup.py

+ 0 - 10
radicale/tests/test_auth.py

@@ -44,16 +44,6 @@ class TestBaseAuthRequests(BaseTest):
         """Test htpasswd authentication with user "tmp" and password "bepo" for
            ``test_matrix`` "ascii" or user "😀" and password "🔑" for
            ``test_matrix`` "unicode"."""
-        if htpasswd_encryption == "bcrypt":
-            try:
-                from passlib.exc import MissingBackendError
-                from passlib.hash import bcrypt
-            except ImportError:
-                pytest.skip("passlib[bcrypt] is not installed")
-            try:
-                bcrypt.hash("test-bcrypt-backend")
-            except MissingBackendError:
-                pytest.skip("bcrypt backend for passlib is not installed")
         htpasswd_file_path = os.path.join(self.colpath, ".htpasswd")
         encoding: str = self.configuration.get("encoding", "stock")
         with open(htpasswd_file_path, "w", encoding=encoding) as f:

+ 1 - 3
setup.cfg

@@ -7,9 +7,7 @@ addopts = --typeguard-packages=radicale
 [tox:tox]
 
 [testenv]
-extras =
-    bcrypt
-    test
+extras = test
 deps =
     flake8
     isort

+ 3 - 3
setup.py

@@ -49,8 +49,9 @@ WEB_FILES = ["web/internal_data/css/icon.png",
 install_requires = ["defusedxml", "passlib", "vobject>=0.9.6",
                     "python-dateutil>=2.7.3",
                     "setuptools; python_version<'3.9'"]
+bcrypt_requires = ["passlib[bcrypt]", "bcrypt"]
 # typeguard requires pytest<7
-tests_require = ["pytest<7", "typeguard", "waitress"]
+test_requires = ["pytest<7", "typeguard", "waitress", *bcrypt_requires]
 
 setup(
     name="Radicale",
@@ -69,8 +70,7 @@ setup(
     package_data={"radicale": [*WEB_FILES, "py.typed"]},
     entry_points={"console_scripts": ["radicale = radicale.__main__:run"]},
     install_requires=install_requires,
-    extras_require={"test": tests_require,
-                    "bcrypt": ["passlib[bcrypt]", "bcrypt"]},
+    extras_require={"test": test_requires, "bcrypt": bcrypt_requires},
     keywords=["calendar", "addressbook", "CalDAV", "CardDAV"],
     python_requires=">=3.6.0",
     classifiers=[